From 1d84e61de75e1f4abbab8d1a210003b173191a0e Mon Sep 17 00:00:00 2001
From: AmR EiSa <amreisa@gmail.com>
Date: Tue, 3 Apr 2018 07:27:11 +0200
Subject: [PATCH] * Remove old style QString::null to avoid clang warring.

---
 src/database.cpp                       |  4 +-
 src/databasemodel.cpp                  |  6 +--
 src/databasemodel.h                    |  2 +-
 src/generators/mysqlgenerator.cpp      |  2 +-
 src/generators/postgresqlgenerator.cpp |  6 +--
 src/generators/sqlgeneratorbase.cpp    | 52 +++++++++++++-------------
 src/generators/sqlgeneratorbase_p.h    |  2 +-
 src/generators/sqlitegenerator.cpp     |  2 +-
 src/generators/sqlservergenerator.cpp  |  6 +--
 src/tablemodel.cpp                     |  2 +-
 src/tablemodel.h                       |  8 ++--
 11 files changed, 46 insertions(+), 46 deletions(-)

diff --git a/src/database.cpp b/src/database.cpp
index 0e2518a..40de725 100644
--- a/src/database.cpp
+++ b/src/database.cpp
@@ -448,7 +448,7 @@ QString Database::tableName(QString className)
     if (m)
         return m->name();
     else
-        return QString::null;;
+        return QString();
 }
 
 void Database::setDatabaseName(QString databaseName)
@@ -534,7 +534,7 @@ bool Database::open(bool updateDatabase)
     else if (d->driver == "QSQLITE" || d->driver == "QSQLITE3")
         d->sqlGenertor = new SqliteGenerator(this);
     else if (d->driver == "QODBC" || d->driver == "QODBC3") {
-        QString driverName = QString::null;
+        QString driverName = QString();
         QStringList parts = d->databaseName.toLower().split(';');
         foreach (QString p, parts)
             if (p.trimmed().startsWith("driver="))
diff --git a/src/databasemodel.cpp b/src/databasemodel.cpp
index 0902b7d..87831fd 100644
--- a/src/databasemodel.cpp
+++ b/src/databasemodel.cpp
@@ -31,13 +31,13 @@ QMap<QString, DatabaseModel*> DatabaseModel::_models;
 #define NODE_VERSION "version"
 #define NODE_TABLES  "tables"
 DatabaseModel::DatabaseModel(const QString &name) :
-    QList<TableModel*>(), _databaseClassName(name), _version(QString::null)
+    QList<TableModel*>(), _databaseClassName(name), _version(QString())
 {
     _models.insert(name, this);
 }
 
 DatabaseModel::DatabaseModel(const DatabaseModel &other) :
-    QList<TableModel*>(other), _version(QString::null)
+    QList<TableModel*>(other), _version(QString())
 {
 
 }
@@ -173,7 +173,7 @@ RelationModel *DatabaseModel::relationByTableNames(const QString &masterTableNam
 
 DatabaseModel DatabaseModel::fromJson(QJsonObject &json)
 {
-    DatabaseModel model(QString::null);
+    DatabaseModel model(QString());
 
     model.setVersion(json.value(NODE_VERSION).toString());
 
diff --git a/src/databasemodel.h b/src/databasemodel.h
index 746b86d..6c73a3a 100644
--- a/src/databasemodel.h
+++ b/src/databasemodel.h
@@ -40,7 +40,7 @@ class DatabaseModel : public QList<TableModel *>
     static QMap<QString, DatabaseModel *> _models;
 
 public:
-    DatabaseModel(const QString &name = QString::null);
+    DatabaseModel(const QString &name = QString());
     DatabaseModel(const DatabaseModel &other);
     DatabaseModel(const QJsonObject &json);
     ~DatabaseModel();
diff --git a/src/generators/mysqlgenerator.cpp b/src/generators/mysqlgenerator.cpp
index 166e424..fb279fa 100644
--- a/src/generators/mysqlgenerator.cpp
+++ b/src/generators/mysqlgenerator.cpp
@@ -88,7 +88,7 @@ QString MySqlGenerator::fieldType(FieldModel *field)
                  qPrintable(field->name),
                  QMetaType::typeName(field->type),
                  field->type);
-        dbType = "";
+        dbType = QString();
     }
 
     if(field->typeName == QStringLiteral("Nut::DbGeography"))
diff --git a/src/generators/postgresqlgenerator.cpp b/src/generators/postgresqlgenerator.cpp
index 105e663..6bab95e 100644
--- a/src/generators/postgresqlgenerator.cpp
+++ b/src/generators/postgresqlgenerator.cpp
@@ -92,7 +92,7 @@ QString PostgreSqlGenerator::fieldType(FieldModel *field)
 
     default:
         qDebug() << "Type for " << (int)field->type << field->type << "(" << QMetaType::typeName(field->type) << ")" << "nut supported";
-        dbType = "";
+        dbType = QString();
     }
 
     if(field->type == (unsigned)QMetaType::type("Nut::DbGeography"))
@@ -103,10 +103,10 @@ QString PostgreSqlGenerator::fieldType(FieldModel *field)
 
 QString PostgreSqlGenerator::diff(FieldModel *oldField, FieldModel *newField)
 {
-    QString sql = "";
+    QString sql = QString();
     if(oldField && newField)
         if(*oldField == *newField)
-            return QString::null;
+            return QString();
 
     if(!newField){
         sql = "DROP COLUMN " + oldField->name;
diff --git a/src/generators/sqlgeneratorbase.cpp b/src/generators/sqlgeneratorbase.cpp
index ad64f94..51812cf 100644
--- a/src/generators/sqlgeneratorbase.cpp
+++ b/src/generators/sqlgeneratorbase.cpp
@@ -65,13 +65,13 @@ SqlGeneratorBase::~SqlGeneratorBase()
 QString SqlGeneratorBase::masterDatabaseName(QString databaseName)
 {
     Q_UNUSED(databaseName);
-    return "";
+    return QString();
 }
 
 QString SqlGeneratorBase::createTable(TableModel *table)
 {
     Q_UNUSED(table)
-    return "";
+    return QString();
 }
 
 QString SqlGeneratorBase::saveRecord(Table *t, QString tableName)
@@ -92,15 +92,15 @@ QString SqlGeneratorBase::saveRecord(Table *t, QString tableName)
         Q_UNREACHABLE();
     }
 
-    return "";
+    return QString();
 }
 
 QString SqlGeneratorBase::recordsPhrase(TableModel *table)
 {
     if (!table)
-        return "";
+        return QString();
 
-    QString ret = "";
+    QString ret = QString();
     foreach (FieldModel *f, table->fields()) {
         if (!ret.isEmpty())
             ret.append(", ");
@@ -144,10 +144,10 @@ QStringList SqlGeneratorBase::diff(DatabaseModel lastModel,
 
 QString SqlGeneratorBase::diff(FieldModel *oldField, FieldModel *newField)
 {
-    QString sql = "";
+    QString sql = QString();
     if (oldField && newField)
         if (*oldField == *newField)
-            return QString::null;
+            return QString();
 
     if (!newField) {
         sql = "DROP COLUMN " + oldField->name;
@@ -165,7 +165,7 @@ QString SqlGeneratorBase::diff(TableModel *oldTable, TableModel *newTable)
 {
     if (oldTable && newTable)
         if (*oldTable == *newTable)
-            return "";
+            return QString();
 
     if (!newTable)
         return "DROP TABLE " + oldTable->name();
@@ -235,7 +235,7 @@ QString SqlGeneratorBase::diff(TableModel *oldTable, TableModel *newTable)
 QString SqlGeneratorBase::diffRelation(TableModel *oldTable, TableModel *newTable)
 {
     if (!newTable)
-        return "";
+        return QString();
 
     QList<QString> relations;
 
@@ -264,7 +264,7 @@ QString SqlGeneratorBase::diffRelation(TableModel *oldTable, TableModel *newTabl
         return "ALTER TABLE " + newTable->name() + "\n"
                 + columnSql.join(",\n");
     else
-        return "";
+        return QString();
 
 }
 
@@ -297,7 +297,7 @@ QString SqlGeneratorBase::diff(RelationModel *oldRel, RelationModel *newRel)
                 .arg(oldRel->foreignColumn);
 
 //    if (*oldRel == *newRel)
-        return "";
+        return QString();
 }
 
 QString SqlGeneratorBase::join(const QString &mainTable,
@@ -340,7 +340,7 @@ QString SqlGeneratorBase::join(const QStringList &list, QStringList *order)
      */
 
     if (!list.count())
-        return "";
+        return QString();
 
     if (list.count() == 1)
         return "[" + list.first() + "]";
@@ -394,7 +394,7 @@ QString SqlGeneratorBase::join(const QStringList &list, QStringList *order)
 
 QString SqlGeneratorBase::insertRecord(Table *t, QString tableName)
 {
-    QString sql = "";
+    QString sql = QString();
     QString key = t->primaryKey();
     QStringList values;
 
@@ -403,7 +403,7 @@ QString SqlGeneratorBase::insertRecord(Table *t, QString tableName)
             values.append("'" + t->property(f.toLatin1().data()).toString()
                           + "'");
 
-    QString changedPropertiesText = "";
+    QString changedPropertiesText = QString();
     QSet<QString> props = t->changedProperties();
     foreach (QString s, props) {
         if (changedPropertiesText != "")
@@ -422,7 +422,7 @@ QString SqlGeneratorBase::insertRecord(Table *t, QString tableName)
 
 QString SqlGeneratorBase::updateRecord(Table *t, QString tableName)
 {
-    QString sql = "";
+    QString sql = QString();
     QString key = t->primaryKey();
     QStringList values;
 
@@ -476,7 +476,7 @@ QString SqlGeneratorBase::agregateText(const AgregateType &t,
         break;
 
     default:
-        return QString::null;
+        return QString();
     }
 }
 
@@ -502,7 +502,7 @@ QString SqlGeneratorBase::fromTableText(const QString &tableName,
                      qPrintable(tableName),
                      qPrintable(joinClassName),
                      qPrintable(joinTableName.isNull() ? "NULL" : joinTableName));
-            joinClassName = QString::null;
+            joinClassName = QString();
         }
     }
 
@@ -511,7 +511,7 @@ QString SqlGeneratorBase::fromTableText(const QString &tableName,
 
 QString SqlGeneratorBase::deleteRecords(QString tableName, QString where)
 {
-    QString sql = "";
+    QString sql = QString();
     if (where.isEmpty() || where.isNull())
         sql = "DELETE FROM " + tableName;
     else
@@ -540,7 +540,7 @@ QString SqlGeneratorBase::selectCommand(const QString &tableName,
         foreach (RelationModel *rel, joins)
             tables << rel->masterTable << rel->slaveTable;
 
-        selectText = "";
+        selectText = QString();
         foreach (TableModel *t, tables) {
             if (!selectText.isEmpty())
                 selectText.append(", ");
@@ -625,7 +625,7 @@ QString SqlGeneratorBase::updateCommand(const QString &tableName,
                                         const AssignmentPhraseList &assigments,
                                         const ConditionalPhrase &where)
 {
-    QString assigmentTexts = "";
+    QString assigmentTexts = QString();
     foreach (PhraseData *d, assigments.data) {
         if (assigmentTexts != "")
             assigmentTexts.append(", ");
@@ -821,7 +821,7 @@ QString SqlGeneratorBase::escapeValue(const QVariant &v) const
 
     default:
         Q_UNREACHABLE();
-        return "";
+        return QString();
     }
 }
 
@@ -834,7 +834,7 @@ QVariant SqlGeneratorBase::readValue(const QVariant::Type &type,
 
 QString SqlGeneratorBase::phrase(const PhraseData *d) const
 {
-    QString ret = "";
+    QString ret = QString();
 
     switch (d->type) {
     case PhraseData::Field:
@@ -939,9 +939,9 @@ void SqlGeneratorBase::appendSkipTake(QString &sql, int skip, int take)
 QString SqlGeneratorBase::createConditionalPhrase(const PhraseData *d) const
 {
     if (!d)
-        return "";
+        return QString();
 
-    QString ret = "";
+    QString ret = QString();
 
     PhraseData::Condition op = d->operatorCond;
     //apply not (!)
@@ -999,7 +999,7 @@ QString SqlGeneratorBase::createConditionalPhrase(const PhraseData *d) const
 
 QString SqlGeneratorBase::createOrderPhrase(const PhraseList &ph)
 {
-    QString ret = "";
+    QString ret = QString();
     foreach (const PhraseData *d, ph.data) {
         if (ret != "")
             ret.append(", ");
@@ -1013,7 +1013,7 @@ QString SqlGeneratorBase::createOrderPhrase(const PhraseList &ph)
 
 QString SqlGeneratorBase::createFieldPhrase(const PhraseList &ph)
 {
-    QString ret = "";
+    QString ret = QString();
     foreach (const PhraseData *d, ph.data) {
         if (ret != "")
             ret.append(", ");
diff --git a/src/generators/sqlgeneratorbase_p.h b/src/generators/sqlgeneratorbase_p.h
index 1c5d98f..4781ae2 100644
--- a/src/generators/sqlgeneratorbase_p.h
+++ b/src/generators/sqlgeneratorbase_p.h
@@ -131,7 +131,7 @@ protected:
     QString createOrderPhrase(const PhraseList &ph);
     void createInsertPhrase(const AssignmentPhraseList &ph, QString &fields, QString &values);
 
-    QString agregateText(const AgregateType &t, const QString &arg = QString::null) const;
+    QString agregateText(const AgregateType &t, const QString &arg = QString()) const;
     QString fromTableText(const QString &tableName, QString &joinClassName, QString &orderBy) const;
 //    QString createWhere(QList<WherePhrase> &wheres);
     void replaceTableNames(QString &command);
diff --git a/src/generators/sqlitegenerator.cpp b/src/generators/sqlitegenerator.cpp
index 83ab286..6e8d774 100644
--- a/src/generators/sqlitegenerator.cpp
+++ b/src/generators/sqlitegenerator.cpp
@@ -65,7 +65,7 @@ QString SqliteGenerator::fieldType(FieldModel *field)
             dbType = "text";
         break;
     default:
-        dbType = "";
+        dbType = QString();
     }
 
     return dbType;
diff --git a/src/generators/sqlservergenerator.cpp b/src/generators/sqlservergenerator.cpp
index 7d0e128..60237e5 100644
--- a/src/generators/sqlservergenerator.cpp
+++ b/src/generators/sqlservergenerator.cpp
@@ -92,7 +92,7 @@ QString SqlServerGenerator::fieldType(FieldModel *field)
 
     default:
         Q_UNREACHABLE();
-        dbType = "";
+        dbType = QString();
     }
 
     return dbType;
@@ -100,10 +100,10 @@ QString SqlServerGenerator::fieldType(FieldModel *field)
 
 QString SqlServerGenerator::diff(FieldModel *oldField, FieldModel *newField)
 {
-    QString sql = "";
+    QString sql = QString();
     if (oldField && newField)
         if (*oldField == *newField)
-            return QString::null;
+            return QString();
 
     if (!newField) {
         sql = "DROP COLUMN " + oldField->name;
diff --git a/src/tablemodel.cpp b/src/tablemodel.cpp
index b77c173..bc542a0 100644
--- a/src/tablemodel.cpp
+++ b/src/tablemodel.cpp
@@ -402,7 +402,7 @@ QString TableModel::primaryKey() const
     foreach (FieldModel *f, _fields)
         if(f->isPrimaryKey)
             return f->name;
-    return QString::null;
+    return QString();
 }
 
 FieldModel::FieldModel(const QJsonObject &json)
diff --git a/src/tablemodel.h b/src/tablemodel.h
index 3a4ec06..67fcc5e 100644
--- a/src/tablemodel.h
+++ b/src/tablemodel.h
@@ -31,7 +31,7 @@ NUT_BEGIN_NAMESPACE
 
 class TableModel;
 struct FieldModel{
-    explicit FieldModel() : name(QString::null), length(0), defaultValue(QString::null),
+    explicit FieldModel() : name(QString()), length(0), defaultValue(QString()),
         notNull(false), isPrimaryKey(false), isAutoIncrement(false), isUnique(false)
     {
 
@@ -70,8 +70,8 @@ struct FieldModel{
 };
 
 struct RelationModel{
-    RelationModel() : localColumn(""), localProperty(""), slaveTable(0),
-        foreignColumn(""), masterTable(0), masterClassName("")
+    RelationModel() : localColumn(QString()), localProperty(QString()), slaveTable(0),
+        foreignColumn(QString()), masterTable(0), masterClassName(QString())
     {}
     explicit RelationModel(const QJsonObject &obj);
 
@@ -92,7 +92,7 @@ bool operator !=(const RelationModel &l, const RelationModel &r);
 class   TableModel
 {
 public:
-    explicit TableModel(int typeId, QString tableName = QString::null);
+    explicit TableModel(int typeId, QString tableName = QString());
     explicit TableModel(QJsonObject json, QString tableName);
     virtual ~TableModel();