From 0955bd714fbd3b35d4823a3d0b990a938ee3841d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20=C5=BBak?= Date: Mon, 7 Nov 2022 11:07:10 +0100 Subject: [PATCH] chore: Enable asciicheck, asasalint, bidichk and exportloopref linters (#12169) --- .golangci.yml | 4 ++++ plugins/outputs/cloudwatch_logs/cloudwatch_logs.go | 5 +++-- plugins/outputs/kafka/kafka.go | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 6c4294a9e..725e204d7 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -2,8 +2,12 @@ linters: disable-all: true enable: # - telegraflinter + - asciicheck + - asasalint + - bidichk - bodyclose - dogsled + - exportloopref - errcheck - goprintffuncname - gosimple diff --git a/plugins/outputs/cloudwatch_logs/cloudwatch_logs.go b/plugins/outputs/cloudwatch_logs/cloudwatch_logs.go index 320803cbb..d931f6d4e 100644 --- a/plugins/outputs/cloudwatch_logs/cloudwatch_logs.go +++ b/plugins/outputs/cloudwatch_logs/cloudwatch_logs.go @@ -174,9 +174,10 @@ func (c *CloudWatchLogs) Connect() error { queryToken = logGroupsOutput.NextToken for _, logGroup := range logGroupsOutput.LogGroups { - if *(logGroup.LogGroupName) == c.LogGroup { + lg := logGroup + if *(lg.LogGroupName) == c.LogGroup { c.Log.Debugf("Found log group %q", c.LogGroup) - c.lg = &logGroup //nolint:revive + c.lg = &lg } } } diff --git a/plugins/outputs/kafka/kafka.go b/plugins/outputs/kafka/kafka.go index a7b384175..f2189bc0f 100644 --- a/plugins/outputs/kafka/kafka.go +++ b/plugins/outputs/kafka/kafka.go @@ -80,7 +80,7 @@ func (l *DebugLogger) Printf(format string, v ...interface{}) { } func (l *DebugLogger) Println(v ...interface{}) { - l.Print(v) + l.Print(v...) } func ValidateTopicSuffixMethod(method string) error {