From 121ae1faaa28a5c21c79eeb5f54f94e6be3c739f Mon Sep 17 00:00:00 2001 From: Joshua Powers Date: Wed, 24 Nov 2021 12:19:25 -0700 Subject: [PATCH] fix: check error before defer in prometheus k8s (#10091) --- plugins/inputs/prometheus/kubernetes.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/inputs/prometheus/kubernetes.go b/plugins/inputs/prometheus/kubernetes.go index 9a4d6bd32..e3217e697 100644 --- a/plugins/inputs/prometheus/kubernetes.go +++ b/plugins/inputs/prometheus/kubernetes.go @@ -110,10 +110,10 @@ func (p *Prometheus) watchPod(ctx context.Context, client *kubernetes.Clientset) LabelSelector: p.KubernetesLabelSelector, FieldSelector: p.KubernetesFieldSelector, }) - defer watcher.Stop() if err != nil { return err } + defer watcher.Stop() for { select {