CL-Softwares
/
telegraf
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Provide detailed error message in telegraf log (#9466)

This commit is contained in:
Madhushree Sreenivasa 2021-07-13 14:08:41 -07:00 committed by GitHub
parent f2d9dbe8cc
commit 2267733a04
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
plugins/inputs/sqlserver/sqlserver.go
View File

@ -256,11 +256,12 @@ func (s *SQLServer) Gather(acc telegraf.Accumulator) error {
wg.Add(1) wg.Add(1)
go func(pool *sql.DB, query Query, serverIndex int) { go func(pool *sql.DB, query Query, serverIndex int) {
defer wg.Done() defer wg.Done()
queryError := s.gatherServer(pool, query, acc) connectionString := s.Servers[serverIndex]
queryError := s.gatherServer(pool, query, acc, connectionString)
if s.HealthMetric { if s.HealthMetric {
mutex.Lock() mutex.Lock()
s.gatherHealth(healthMetrics, s.Servers[serverIndex], queryError) s.gatherHealth(healthMetrics, connectionString, queryError)
mutex.Unlock() mutex.Unlock()
} }
@ -344,12 +345,21 @@ func (s *SQLServer) Stop() {
} }
} }
func (s *SQLServer) gatherServer(pool *sql.DB, query Query, acc telegraf.Accumulator) error { func (s *SQLServer) gatherServer(pool *sql.DB, query Query, acc telegraf.Accumulator, connectionString string) error {
// execute query // execute query
rows, err := pool.Query(query.Script) rows, err := pool.Query(query.Script)
if err != nil { if err != nil {
return fmt.Errorf("script %s failed: %w", query.ScriptName, err) serverName, databaseName := getConnectionIdentifiers(connectionString)
// Error msg based on the format in SSMS. SQLErrorClass() is another term for severity/level: http://msdn.microsoft.com/en-us/library/dd304156.aspx
if sqlerr, ok := err.(mssql.Error); ok {
return fmt.Errorf("Query %s failed for server: %s and database: %s with Msg %d, Level %d, State %d:, Line %d, Error: %w", query.ScriptName,
serverName, databaseName, sqlerr.SQLErrorNumber(), sqlerr.SQLErrorClass(), sqlerr.SQLErrorState(), sqlerr.SQLErrorLineNo(), err)
}
return fmt.Errorf("Query %s failed for server: %s and database: %s with Error: %w", query.ScriptName, serverName, databaseName, err)
} }
defer rows.Close() defer rows.Close()
// grab the column information from the result // grab the column information from the result