CL-Softwares
/
telegraf
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test(processors.snmp_lookup): Fix race in test (#14924)

This commit is contained in:
Sven Rebhan 2024-03-05 16:35:41 +01:00 committed by GitHub
parent ebea0b289a
commit 31f70e6290
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
plugins/processors/snmp_lookup/store_test.go
View File

@ -16,14 +16,21 @@ func TestAddBacklog(t *testing.T) {
s.notify = func(string, *tagMap) { notifyCount.Add(1) }
defer s.destroy()
s.Lock()
require.Empty(t, s.deferredUpdates)
s.Unlock()
s.addBacklog("127.0.0.1", time.Now().Add(10*time.Millisecond))
s.addBacklog("127.0.0.1", time.Now().Add(1*time.Second))
s.Lock()
require.Contains(t, s.deferredUpdates, "127.0.0.1")
s.Unlock()
require.Eventually(t, func() bool {
return notifyCount.Load() == 1
}, time.Second, time.Millisecond)
}, 3*time.Second, 100*time.Millisecond)
s.Lock()
require.Empty(t, s.deferredUpdates)
s.Unlock()
}
func TestLookup(t *testing.T) {
@ -57,17 +64,28 @@ func TestLookup(t *testing.T) {
require.Equal(t, tmr, entries.rows)
// Second lookup should be deferred minUpdateInterval
s.Lock()
require.Empty(t, s.deferredUpdates)
s.Unlock()
s.lookup("127.0.0.1", "999")
require.EqualValues(t, 2, notifyCount.Load())
s.Lock()
require.Contains(t, s.deferredUpdates, "127.0.0.1")
require.WithinDuration(t, time.Now(), s.deferredUpdates["127.0.0.1"], minUpdateInterval)
s.Unlock()
// Wait until resolved
require.Eventually(t, func() bool {
return notifyCount.Load() == 3
}, time.Second, time.Millisecond)
s.Lock()
require.Empty(t, s.deferredUpdates)
s.Unlock()
time.Sleep(minUpdateInterval)
// Third lookup should directly update