From 35e79fd82434378fd150cdd3c61229cf23b325ec Mon Sep 17 00:00:00 2001
From: Dane Strandboge <136023093+DStrand1@users.noreply.github.com>
Date: Fri, 16 Feb 2024 03:41:39 -0600
Subject: [PATCH] test(processors.strings): Add unit test for tracking metrics
 (#14831)

---
 plugins/processors/strings/strings_test.go | 41 ++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/plugins/processors/strings/strings_test.go b/plugins/processors/strings/strings_test.go
index d6da6496d..ed23e91fe 100644
--- a/plugins/processors/strings/strings_test.go
+++ b/plugins/processors/strings/strings_test.go
@@ -1,6 +1,8 @@
 package strings
 
 import (
+	"strconv"
+	"sync"
 	"testing"
 	"time"
 
@@ -1158,3 +1160,42 @@ func TestValidUTF8(t *testing.T) {
 		})
 	}
 }
+
+func TestTrackedMetricNotLost(t *testing.T) {
+	var mu sync.Mutex
+	delivered := make([]telegraf.DeliveryInfo, 0, 3)
+	notify := func(di telegraf.DeliveryInfo) {
+		mu.Lock()
+		defer mu.Unlock()
+		delivered = append(delivered, di)
+	}
+	input := make([]telegraf.Metric, 0, 3)
+	expected := make([]telegraf.Metric, 0, 6)
+	for i := 0; i < 3; i++ {
+		strI := strconv.Itoa(i)
+
+		m := metric.New("m"+strI, map[string]string{}, map[string]interface{}{"message": "test" + string([]byte{0xff}) + strI}, time.Unix(0, 0))
+		tm, _ := metric.WithTracking(m, notify)
+		input = append(input, tm)
+
+		m = metric.New("m"+strI, map[string]string{}, map[string]interface{}{"message": "test" + strI}, time.Unix(0, 0))
+		expected = append(expected, m)
+	}
+
+	// Process expected metrics and compare with resulting metrics
+	plugin := &Strings{ValidUTF8: []converter{{Field: "message", Replacement: ""}}}
+	actual := plugin.Apply(input...)
+	testutil.RequireMetricsEqual(t, expected, actual)
+
+	// Simulate output acknowledging delivery
+	for _, m := range actual {
+		m.Accept()
+	}
+
+	// Check delivery
+	require.Eventuallyf(t, func() bool {
+		mu.Lock()
+		defer mu.Unlock()
+		return len(input) == len(delivered)
+	}, time.Second, 100*time.Millisecond, "%d delivered but %d expected", len(delivered), len(expected))
+}