chore(linters): Enable `datarace` rule for revive (#15984)

.golangci.yml

@@ -254,6 +254,7 @@ linters-settings:
       - name: constant-logical-expr
       - name: context-as-argument
       - name: context-keys-type
+      - name: datarace
       - name: deep-exit
       - name: defer
       - name: dot-imports

plugins/common/shim/goshim_test.go

@@ -31,9 +31,9 @@ func TestShimSetsUpLogger(t *testing.T) {
 	require.NoError(t, err)
 }
 
-func runErroringInputPlugin(t *testing.T, interval time.Duration, stdin io.Reader, stdout, stderr io.Writer) (metricProcessed chan bool, exited chan bool) {
+func runErroringInputPlugin(t *testing.T, interval time.Duration, stdin io.Reader, stdout, stderr io.Writer) (chan bool, chan bool) {
-	metricProcessed = make(chan bool, 1)
+	metricProcessed := make(chan bool, 1)
-	exited = make(chan bool, 1)
+	exited := make(chan bool, 1)
 	inp := &erroringInput{}
 
 	shim := New()

plugins/common/shim/input_test.go

@@ -54,9 +54,9 @@ func TestInputShimStdinSignalingWorks(t *testing.T) {
 	<-exited
 }
 
-func runInputPlugin(t *testing.T, interval time.Duration, stdin io.Reader, stdout, stderr io.Writer) (metricProcessed chan bool, exited chan bool) {
+func runInputPlugin(t *testing.T, interval time.Duration, stdin io.Reader, stdout, stderr io.Writer) (chan bool, chan bool) {
-	metricProcessed = make(chan bool, 1)
+	metricProcessed := make(chan bool, 1)
-	exited = make(chan bool, 1)
+	exited := make(chan bool, 1)
 	inp := &testInput{
 		metricProcessed: metricProcessed,
 	}

plugins/inputs/execd/shim/shim_test.go

@@ -53,9 +53,9 @@ func TestShimStdinSignalingWorks(t *testing.T) {
 	<-exited
 }
 
-func runInputPlugin(t *testing.T, interval time.Duration, stdin io.Reader, stdout, stderr io.Writer) (metricProcessed, exited chan bool) {
+func runInputPlugin(t *testing.T, interval time.Duration, stdin io.Reader, stdout, stderr io.Writer) (chan bool, chan bool) {
-	metricProcessed = make(chan bool)
+	metricProcessed := make(chan bool)
-	exited = make(chan bool)
+	exited := make(chan bool)
 	inp := &testInput{
 		metricProcessed: metricProcessed,
 	}