CL-Softwares
/
telegraf
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(inputs.smart): Add additional SMART metrics that indicate/predict device failure (#12329)

This commit is contained in:
Pranay Kanwar 2022-12-09 21:16:21 +05:30 committed by GitHub
parent 375e089d12
commit 4161651fed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/inputs/smart/smart.go
View File

@ -80,10 +80,19 @@ var (
deviceFieldIds = map[string]string{ deviceFieldIds = map[string]string{
"1": "read_error_rate", "1": "read_error_rate",
"5": "reallocated_sectors_count",
"7": "seek_error_rate", "7": "seek_error_rate",
"10": "spin_retry_count",
"184": "end_to_end_error",
"187": "uncorrectable_errors",
"188": "command_timeout",
"190": "temp_c", "190": "temp_c",
"194": "temp_c", "194": "temp_c",
"196": "realloc_event_count",
"197": "pending_sector_count",
"198": "uncorrectable_sector_count",
"199": "udma_crc_errors", "199": "udma_crc_errors",
"201": "soft_read_error_rate",
} }
// There are some fields we're interested in which use the vendor specific device ids // There are some fields we're interested in which use the vendor specific device ids

26
plugins/inputs/smart/smart_test.go
View File

@ -52,7 +52,7 @@ func TestGatherAttributes(t *testing.T) {
err := s.Gather(&acc) err := s.Gather(&acc)
require.NoError(t, err) require.NoError(t, err)
assert.Equal(t, 66, acc.NFields(), "Wrong number of fields gathered") assert.Equal(t, 68, acc.NFields(), "Wrong number of fields gathered")
for _, test := range testsAda0Attributes { for _, test := range testsAda0Attributes {
acc.AssertContainsTaggedFields(t, "smart_attribute", test.fields, test.tags) acc.AssertContainsTaggedFields(t, "smart_attribute", test.fields, test.tags)
@ -171,7 +171,7 @@ func TestGatherNoAttributes(t *testing.T) {
err := s.Gather(&acc) err := s.Gather(&acc)
require.NoError(t, err) require.NoError(t, err)
assert.Equal(t, 9, acc.NFields(), "Wrong number of fields gathered") assert.Equal(t, 11, acc.NFields(), "Wrong number of fields gathered")
acc.AssertDoesNotContainMeasurement(t, "smart_attribute") acc.AssertDoesNotContainMeasurement(t, "smart_attribute")
for _, test := range testsAda0Device { for _, test := range testsAda0Device {
@ -212,7 +212,7 @@ func TestGatherSATAInfo(t *testing.T) {
wg.Add(1) wg.Add(1)
sampleSmart.gatherDisk(acc, "", wg) sampleSmart.gatherDisk(acc, "", wg)
assert.Equal(t, 101, acc.NFields(), "Wrong number of fields gathered") assert.Equal(t, 106, acc.NFields(), "Wrong number of fields gathered")
assert.Equal(t, uint64(20), acc.NMetrics(), "Wrong number of metrics gathered") assert.Equal(t, uint64(20), acc.NMetrics(), "Wrong number of metrics gathered")
} }
@ -228,7 +228,7 @@ func TestGatherSATAInfo65(t *testing.T) {
wg.Add(1) wg.Add(1)
sampleSmart.gatherDisk(acc, "", wg) sampleSmart.gatherDisk(acc, "", wg)
assert.Equal(t, 91, acc.NFields(), "Wrong number of fields gathered") assert.Equal(t, 96, acc.NFields(), "Wrong number of fields gathered")
assert.Equal(t, uint64(18), acc.NMetrics(), "Wrong number of metrics gathered") assert.Equal(t, uint64(18), acc.NMetrics(), "Wrong number of metrics gathered")
} }
@ -293,7 +293,7 @@ func TestGatherSSD(t *testing.T) {
wg.Add(1) wg.Add(1)
sampleSmart.gatherDisk(acc, "", wg) sampleSmart.gatherDisk(acc, "", wg)
assert.Equal(t, 106, acc.NFields(), "Wrong number of fields gathered") assert.Equal(t, 110, acc.NFields(), "Wrong number of fields gathered")
assert.Equal(t, uint64(26), acc.NMetrics(), "Wrong number of metrics gathered") assert.Equal(t, uint64(26), acc.NMetrics(), "Wrong number of metrics gathered")
} }
@ -309,7 +309,7 @@ func TestGatherSSDRaid(t *testing.T) {
wg.Add(1) wg.Add(1)
sampleSmart.gatherDisk(acc, "", wg) sampleSmart.gatherDisk(acc, "", wg)
assert.Equal(t, 75, acc.NFields(), "Wrong number of fields gathered") assert.Equal(t, 77, acc.NFields(), "Wrong number of fields gathered")
assert.Equal(t, uint64(15), acc.NMetrics(), "Wrong number of metrics gathered") assert.Equal(t, uint64(15), acc.NMetrics(), "Wrong number of metrics gathered")
} }
@ -1411,12 +1411,14 @@ var (
}{ }{
{ {
map[string]interface{}{ map[string]interface{}{
"exit_status": int(0), "exit_status": int(0),
"health_ok": bool(true), "health_ok": bool(true),
"read_error_rate": int64(0), "read_error_rate": int64(0),
"temp_c": int64(34), "temp_c": int64(34),
"udma_crc_errors": int64(0), "udma_crc_errors": int64(0),
"wear_leveling_count": int64(185), "wear_leveling_count": int64(185),
"pending_sector_count": int64(0),
"reallocated_sectors_count": int64(0),
}, },
map[string]string{ map[string]string{
"device": "ada0", "device": "ada0",