CL-Softwares
/
telegraf
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: avoid data race in tcp-listener test (#11144)

This commit is contained in:
Sven Rebhan 2022-05-23 21:01:53 +02:00 committed by GitHub
parent 0ff3b6339a
commit 4f972daa2b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
plugins/inputs/tcp_listener/tcp_listener_test.go
View File

@ -1,14 +1,9 @@
package tcp_listener package tcp_listener
import ( import (
"bufio"
"bytes"
"fmt" "fmt"
"io" "io"
"log"
"net" "net"
"os"
"strings"
"testing" "testing"
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
@ -255,30 +250,22 @@ func TestRunParser(t *testing.T) {
) )
} }
func TestRunParserInvalidMsg(_ *testing.T) { func TestRunParserInvalidMsg(t *testing.T) {
var testmsg = []byte("cpu_load_short") var testmsg = []byte("cpu_load_short")
listener, in := newTestTCPListener() listener, in := newTestTCPListener()
acc := testutil.Accumulator{} listener.Log = &testutil.CaptureLogger{}
listener.acc = &acc listener.acc = &testutil.Accumulator{}
defer close(listener.done)
listener.parser, _ = parsers.NewInfluxParser() listener.parser, _ = parsers.NewInfluxParser()
listener.wg.Add(1) listener.wg.Add(1)
buf := bytes.NewBuffer(nil)
log.SetOutput(buf)
defer log.SetOutput(os.Stderr)
go listener.tcpParser() go listener.tcpParser()
in <- testmsg in <- testmsg
scnr := bufio.NewScanner(buf) listener.Stop()
for scnr.Scan() { errmsg := listener.Log.(*testutil.CaptureLogger).LastError
if strings.Contains(scnr.Text(), "tcp_listener has received 1 malformed packets thus far.") { require.Contains(t, errmsg, "tcp_listener has received 1 malformed packets thus far.")
break
}
}
} }
func TestRunParserGraphiteMsg(t *testing.T) { func TestRunParserGraphiteMsg(t *testing.T) {