Close file to ensure it has been flushed (#7819)

This commit is contained in:
Daniel Nelson 2020-07-10 10:59:06 -07:00 committed by GitHub
parent 4c4945fecc
commit 51f6cc36cd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 10 deletions

View File

@ -22,7 +22,6 @@ func TestTailBadLine(t *testing.T) {
tmpfile, err := ioutil.TempFile("", "")
require.NoError(t, err)
defer os.Remove(tmpfile.Name())
defer tmpfile.Close()
_, err = tmpfile.WriteString("cpu mytag= foo usage_idle= 100\n")
require.NoError(t, err)
@ -31,6 +30,8 @@ func TestTailBadLine(t *testing.T) {
_, err = tmpfile.WriteString("cpu usage_idle=100\n")
require.NoError(t, err)
tmpfile.Close()
tt := NewTail()
tt.Log = testutil.Logger{}
tt.FromBeginning = true
@ -58,9 +59,9 @@ func TestTailDosLineendings(t *testing.T) {
tmpfile, err := ioutil.TempFile("", "")
require.NoError(t, err)
defer os.Remove(tmpfile.Name())
defer tmpfile.Close()
_, err = tmpfile.WriteString("cpu usage_idle=100\r\ncpu2 usage_idle=200\r\n")
require.NoError(t, err)
tmpfile.Close()
tt := NewTail()
tt.Log = testutil.Logger{}
@ -91,10 +92,7 @@ func TestTailDosLineendings(t *testing.T) {
func TestCSVHeadersParsedOnce(t *testing.T) {
tmpfile, err := ioutil.TempFile("", "")
require.NoError(t, err)
defer func() {
tmpfile.Close()
os.Remove(tmpfile.Name())
}()
defer os.Remove(tmpfile.Name())
_, err = tmpfile.WriteString(`
measurement,time_idle
@ -102,6 +100,7 @@ cpu,42
cpu,42
`)
require.NoError(t, err)
tmpfile.Close()
plugin := NewTail()
plugin.Log = testutil.Logger{}
@ -152,15 +151,13 @@ cpu,42
func TestMultipleMetricsOnFirstLine(t *testing.T) {
tmpfile, err := ioutil.TempFile("", "")
require.NoError(t, err)
defer func() {
tmpfile.Close()
os.Remove(tmpfile.Name())
}()
defer os.Remove(tmpfile.Name())
_, err = tmpfile.WriteString(`
[{"time_idle": 42}, {"time_idle": 42}]
`)
require.NoError(t, err)
tmpfile.Close()
plugin := NewTail()
plugin.Log = testutil.Logger{}