CL-Softwares
/
telegraf
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore(linters): Enable `unused-receiver` rule for revive (#16406)

This commit is contained in:
Paweł Żak 2025-01-17 11:12:49 +01:00 committed by GitHub
parent 09e3b59eb4
commit 7a92925f00
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.golangci.yml
View File

@ -318,6 +318,7 @@ linters-settings:
- name: unnecessary-stmt - name: unnecessary-stmt
- name: unreachable-code - name: unreachable-code
- name: unused-parameter - name: unused-parameter
- name: unused-receiver
- name: var-declaration - name: var-declaration
- name: var-naming - name: var-naming
- name: waitgroup-by-value - name: waitgroup-by-value

2
plugins/inputs/processes/processes_windows.go
View File

@ -16,7 +16,7 @@ func (e *Processes) Init() error {
return nil return nil
} }
func (e *Processes) Gather(_ telegraf.Accumulator) error { func (*Processes) Gather(telegraf.Accumulator) error {
return nil return nil
} }

2
plugins/inputs/temp/temp_notlinux.go
View File

@ -25,7 +25,7 @@ func (t *Temperature) Init() error {
return nil return nil
} }
func (t *Temperature) Gather(acc telegraf.Accumulator) error { func (*Temperature) Gather(acc telegraf.Accumulator) error {
temps, err := sensors.SensorsTemperatures() temps, err := sensors.SensorsTemperatures()
if err != nil { if err != nil {
var sensorsWarnings *sensors.Warnings var sensorsWarnings *sensors.Warnings

4
plugins/inputs/win_eventlog/win_eventlog.go
View File

@ -113,7 +113,7 @@ func (w *WinEventLog) Stop() {
} }
func (w *WinEventLog) GetState() interface{} { func (w *WinEventLog) GetState() interface{} {
bookmarkXML, err := w.renderBookmark(w.bookmark) bookmarkXML, err := renderBookmark(w.bookmark)
if err != nil { if err != nil {
w.Log.Errorf("State-persistence failed, cannot render bookmark: %v", err) w.Log.Errorf("State-persistence failed, cannot render bookmark: %v", err)
return "" return ""
@ -381,7 +381,7 @@ func (w *WinEventLog) fetchEvents(subsHandle EvtHandle) ([]Event, error) {
return events, evterr return events, evterr
} }
func (w *WinEventLog) renderBookmark(bookmark EvtHandle) (string, error) { func renderBookmark(bookmark EvtHandle) (string, error) {
var bufferUsed, propertyCount uint32 var bufferUsed, propertyCount uint32
buf := make([]byte, bufferSize) buf := make([]byte, bufferSize)

6
plugins/inputs/win_perf_counters/performance_query.go
View File

@ -69,7 +69,7 @@ type performanceQueryImpl struct {
type performanceQueryCreatorImpl struct{} type performanceQueryCreatorImpl struct{}
func (m performanceQueryCreatorImpl) NewPerformanceQuery(_ string, maxBufferSize uint32) PerformanceQuery { func (performanceQueryCreatorImpl) NewPerformanceQuery(_ string, maxBufferSize uint32) PerformanceQuery {
return &performanceQueryImpl{maxBufferSize: maxBufferSize} return &performanceQueryImpl{maxBufferSize: maxBufferSize}
} }
@ -181,7 +181,7 @@ func (m *performanceQueryImpl) ExpandWildCardPath(counterPath string) ([]string,
} }
// GetFormattedCounterValueDouble computes a displayable value for the specified counter // GetFormattedCounterValueDouble computes a displayable value for the specified counter
func (m *performanceQueryImpl) GetFormattedCounterValueDouble(hCounter pdhCounterHandle) (float64, error) { func (*performanceQueryImpl) GetFormattedCounterValueDouble(hCounter pdhCounterHandle) (float64, error) {
var counterType uint32 var counterType uint32
var value pdhFmtCountervalueDouble var value pdhFmtCountervalueDouble
@ -287,7 +287,7 @@ func (m *performanceQueryImpl) CollectDataWithTime() (time.Time, error) {
return mtime, nil return mtime, nil
} }
func (m *performanceQueryImpl) IsVistaOrNewer() bool { func (*performanceQueryImpl) IsVistaOrNewer() bool {
return PdhAddEnglishCounterSupported() return PdhAddEnglishCounterSupported()
} }

2
plugins/inputs/win_perf_counters/win_perf_counters.go
View File

@ -153,7 +153,7 @@ func extractCounterInfoFromCounterPath(counterPath string) (computer string, obj
return computer, object, instance, counter, nil return computer, object, instance, counter, nil
} }
func (m *WinPerfCounters) SampleConfig() string { func (*WinPerfCounters) SampleConfig() string {
return sampleConfig return sampleConfig
} }

2
plugins/inputs/win_services/win_services.go
View File

@ -89,7 +89,7 @@ func (m *winSvcMgr) ListServices() ([]string, error) {
type mgProvider struct { type mgProvider struct {
} }
func (rmr *mgProvider) Connect() (WinServiceManager, error) { func (*mgProvider) Connect() (WinServiceManager, error) {
h, err := windows.OpenSCManager(nil, nil, windows.GENERIC_READ) h, err := windows.OpenSCManager(nil, nil, windows.GENERIC_READ)
if err != nil { if err != nil {
return nil, err return nil, err

4
plugins/inputs/win_services/win_services_test.go
View File

@ -39,7 +39,7 @@ type FakeSvcMgr struct {
testData testData testData testData
} }
func (m *FakeSvcMgr) Disconnect() error { func (*FakeSvcMgr) Disconnect() error {
return nil return nil
} }
@ -77,7 +77,7 @@ type FakeWinSvc struct {
testData serviceTestInfo testData serviceTestInfo
} }
func (m *FakeWinSvc) Close() error { func (*FakeWinSvc) Close() error {
return nil return nil
} }
func (m *FakeWinSvc) Config() (mgr.Config, error) { func (m *FakeWinSvc) Config() (mgr.Config, error) {