From 7fb90a2d9cbe990473ffa1c69b8aea8e104610b8 Mon Sep 17 00:00:00 2001 From: Sven Rebhan <36194019+srebhan@users.noreply.github.com> Date: Fri, 16 Dec 2022 14:26:19 +0100 Subject: [PATCH] chore(linter): disable linter warning for freeze() in starlark (#12406) --- plugins/common/starlark/field_dict.go | 4 ++++ plugins/common/starlark/tag_dict.go | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/plugins/common/starlark/field_dict.go b/plugins/common/starlark/field_dict.go index 746a2ca9f..5356a2de9 100644 --- a/plugins/common/starlark/field_dict.go +++ b/plugins/common/starlark/field_dict.go @@ -38,6 +38,10 @@ func (d FieldDict) Type() string { } func (d FieldDict) Freeze() { + // Disable linter check as the frozen variable is modified despite + // passing a value instead of a pointer, because `FieldDict` holds + // a pointer to the underlying metric containing the `frozen` field. + //revive:disable:modifies-value-receiver d.frozen = true } diff --git a/plugins/common/starlark/tag_dict.go b/plugins/common/starlark/tag_dict.go index 56ee0f655..992d5b298 100644 --- a/plugins/common/starlark/tag_dict.go +++ b/plugins/common/starlark/tag_dict.go @@ -37,6 +37,10 @@ func (d TagDict) Type() string { } func (d TagDict) Freeze() { + // Disable linter check as the frozen variable is modified despite + // passing a value instead of a pointer, because `TagDict` holds + // a pointer to the underlying metric containing the `frozen` field. + //revive:disable:modifies-value-receiver d.frozen = true }