CL-Softwares
/
telegraf
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test(inputs.snmp): Use random port (#12464)

This commit is contained in:
Joshua Powers 2023-01-12 10:30:04 -07:00 committed by GitHub
parent 61523bd4b9
commit a586101d84
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
plugins/inputs/snmp/snmp_test.go
View File

@ -287,44 +287,26 @@ func TestGetSNMPConnection_v2(t *testing.T) {
} }
func TestGetSNMPConnectionTCP(t *testing.T) { func TestGetSNMPConnectionTCP(t *testing.T) {
var wg sync.WaitGroup tcpAddr, err := net.ResolveTCPAddr("tcp", "127.0.0.1:0")
wg.Add(1) require.NoError(t, err)
go stubTCPServer(&wg)
wg.Wait() tcpServer, err := net.ListenTCP("tcp", tcpAddr)
require.NoError(t, err)
defer tcpServer.Close()
s := &Snmp{ s := &Snmp{
Agents: []string{"tcp://127.0.0.1:56789"}, Agents: []string{fmt.Sprintf("tcp://%s", tcpServer.Addr())},
ClientConfig: snmp.ClientConfig{ ClientConfig: snmp.ClientConfig{
Translator: "netsnmp", Translator: "netsnmp",
}, },
} }
err := s.Init() require.NoError(t, s.Init())
require.NoError(t, err)
wg.Add(1)
gsc, err := s.getConnection(0) gsc, err := s.getConnection(0)
require.NoError(t, err) require.NoError(t, err)
gs := gsc.(snmp.GosnmpWrapper) gs := gsc.(snmp.GosnmpWrapper)
assert.Equal(t, "127.0.0.1", gs.Target) assert.Equal(t, "127.0.0.1", gs.Target)
assert.EqualValues(t, 56789, gs.Port)
assert.Equal(t, "tcp", gs.Transport) assert.Equal(t, "tcp", gs.Transport)
wg.Wait()
}
func stubTCPServer(wg *sync.WaitGroup) {
defer wg.Done()
tcpAddr, err := net.ResolveTCPAddr("tcp", "127.0.0.1:56789")
if err != nil {
fmt.Print(err)
}
tcpServer, err := net.ListenTCP("tcp", tcpAddr)
if err != nil {
fmt.Print(err)
}
defer tcpServer.Close()
wg.Done()
conn, _ := tcpServer.AcceptTCP()
defer conn.Close()
} }
func TestGetSNMPConnection_v3(t *testing.T) { func TestGetSNMPConnection_v3(t *testing.T) {