chore(deps): Bump golangci-lint from v2.0.2 to v2.1.2 (#16816)

.circleci/config.yml

@@ -106,7 +106,7 @@ jobs:
       - run: 'make check-deps'
       - run:
           name: "Install golangci-lint"
-          command: go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.0.2
+          command: go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.2
       - run:
           name: "golangci-lint/Linux"
           # There are only 4 vCPUs available for this executor, so use only 4 instead of the default number
@@ -120,7 +120,7 @@ jobs:
       - check-changed-files-or-halt
       - run:
           name: "Install golangci-lint"
-          command: go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.0.2
+          command: go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.2
       - run:
           name: "golangci-lint/macOS"
           # There are only 4 vCPUs available for this executor, so use only 4 instead of the default number
@@ -134,7 +134,7 @@ jobs:
       - check-changed-files-or-halt
       - run:
           name: "Install golangci-lint"
-          command: go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.0.2
+          command: go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.2
       - run:
           name: "golangci-lint/Windows"
           # There are only 4 vCPUs available for this executor, so use only 4 instead of the default number

.golangci.yml

@@ -68,6 +68,7 @@ linters:
           # List of file globs that will match this list of settings to compare against.
           # By default, if a path is relative, it is relative to the directory where the golangci-lint command is executed.
           # The placeholder '${base-path}' is substituted with a path relative to the mode defined with `run.relative-path-mode`.
+          # The placeholder '${config-path}' is substituted with a path relative to the configuration file.
           # Default: $all
           files:
             - '!**/agent/**'
@@ -169,7 +170,7 @@ linters:
 
       # Settings passed to gocritic.
       # The settings key is the name of a supported gocritic checker.
-      # The list of supported checkers can be find in https://go-critic.com/overview.
+      # The list of supported checkers can be found at https://go-critic.com/overview.
       settings:
         hugeParam:
           # Size in bytes that makes the warning trigger.
@@ -470,7 +471,7 @@ linters:
     # - `lax`: sources are excluded if they contain lines like `autogenerated file`, `code generated`, `do not edit`, etc.
     # - `disable`: disable the generated files exclusion.
     #
-    # Default: lax
+    # Default: strict
     generated: lax
 
     # Excluding configuration per-path, per-linter, per-text and per-source.
@@ -528,7 +529,7 @@ formatters:
     gci:
       # Section configuration to compare against.
       # Section names are case-insensitive and may contain parameters in ().
-      # The default order of sections is `standard > default > custom > blank > dot > alias > localmodule`,
+      # The default order of sections is `standard > default > custom > blank > dot > alias > localmodule`.
       # If `custom-order` is `true`, it follows the order of `sections` option.
       # Default: ["standard", "default"]
       sections:

Makefile

@@ -180,7 +180,7 @@ vet:
 .PHONY: lint-install
 lint-install:
 	@echo "Installing golangci-lint"
-	go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.0.2
+	go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.2
 
 	@echo "Installing markdownlint"
 	npm install -g markdownlint-cli

migrations/global_agent/migration_test.go

@@ -88,7 +88,6 @@ func TestCases(t *testing.T) {
 			output, n, err := config.ApplyMigrations(input)
 			require.NoError(t, err)
 			require.NotEmpty(t, output)
-			//nolint:testifylint // "useless-assert: meaningless assertion" - false positive
 			require.Positive(t, n, "expected migration application but none applied")
 			actual := config.NewConfig()
 			require.NoError(t, actual.LoadConfigData(output, config.EmptySourcePath))