CL-Softwares
/
telegraf
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Wrap long lines in plugins/aggregators (#12183)

This commit is contained in:
Paweł Żak 2022-11-08 18:42:36 +01:00 committed by GitHub
parent b9bba638b1
commit c30518d853
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 196 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

224
plugins/aggregators/histogram/histogram_test.go
View File

@ -21,7 +21,13 @@ func NewTestHistogram(cfg []config, reset bool, cumulative bool, pushOnlyOnUpdat
return NewTestHistogramWithExpirationInterval(cfg, reset, cumulative, pushOnlyOnUpdate, 0) return NewTestHistogramWithExpirationInterval(cfg, reset, cumulative, pushOnlyOnUpdate, 0)
} }
func NewTestHistogramWithExpirationInterval(cfg []config, reset bool, cumulative bool, pushOnlyOnUpdate bool, expirationInterval telegrafConfig.Duration) telegraf.Aggregator { func NewTestHistogramWithExpirationInterval(
cfg []config,
reset bool,
cumulative bool,
pushOnlyOnUpdate bool,
expirationInterval telegrafConfig.Duration,
) telegraf.Aggregator {
htm := NewHistogramAggregator() htm := NewHistogramAggregator()
htm.Configs = cfg htm.Configs = cfg
htm.ResetBuckets = reset htm.ResetBuckets = reset
@ -195,18 +201,66 @@ func TestHistogramWithAllFields(t *testing.T) {
require.Len(t, acc.Metrics, 12, "Incorrect number of metrics") require.Len(t, acc.Metrics, 12, "Incorrect number of metrics")
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(0), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketRightTag: "0"}) assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(0), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketRightTag: "0"})
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(1), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketRightTag: "15.5"}) assertContainsTaggedField(
t,
acc,
"first_metric_name",
fields{"a_bucket": int64(1), "b_bucket": int64(0), "c_bucket": int64(0)},
tags{bucketRightTag: "15.5"},
)
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketRightTag: "20"}) assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketRightTag: "20"})
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketRightTag: "30"}) assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketRightTag: "30"})
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(1), "c_bucket": int64(1)}, tags{bucketRightTag: "40"}) assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(1), "c_bucket": int64(1)}, tags{bucketRightTag: "40"})
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(1), "c_bucket": int64(1)}, tags{bucketRightTag: bucketPosInf}) assertContainsTaggedField(
t,
acc,
"first_metric_name",
fields{"a_bucket": int64(2), "b_bucket": int64(1), "c_bucket": int64(1)},
tags{bucketRightTag: bucketPosInf},
)
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketRightTag: "0"}) assertContainsTaggedField(
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketRightTag: "4"}) t,
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketRightTag: "10"}) acc,
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketRightTag: "23"}) "second_metric_name",
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketRightTag: "30"}) fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(1), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketRightTag: bucketPosInf}) tags{bucketRightTag: "0"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketRightTag: "4"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketRightTag: "10"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketRightTag: "23"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketRightTag: "30"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(1), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketRightTag: bucketPosInf},
)
} }
// TestHistogramWithAllFieldsNonCumulative tests two metrics for one period and for all fields // TestHistogramWithAllFieldsNonCumulative tests two metrics for one period and for all fields
@ -224,19 +278,91 @@ func TestHistogramWithAllFieldsNonCumulative(t *testing.T) {
histogram.Push(acc) histogram.Push(acc)
require.Len(t, acc.Metrics, 12, "Incorrect number of metrics") require.Len(t, acc.Metrics, 12, "Incorrect number of metrics")
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(0), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketLeftTag: bucketNegInf, bucketRightTag: "0"}) assertContainsTaggedField(
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(1), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketLeftTag: "0", bucketRightTag: "15.5"}) t,
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(1), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketLeftTag: "15.5", bucketRightTag: "20"}) acc,
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(0), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketLeftTag: "20", bucketRightTag: "30"}) "first_metric_name",
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(0), "b_bucket": int64(1), "c_bucket": int64(1)}, tags{bucketLeftTag: "30", bucketRightTag: "40"}) fields{"a_bucket": int64(0), "b_bucket": int64(0), "c_bucket": int64(0)},
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(0), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketLeftTag: "40", bucketRightTag: bucketPosInf}) tags{bucketLeftTag: bucketNegInf, bucketRightTag: "0"},
)
assertContainsTaggedField(
t,
acc,
"first_metric_name",
fields{"a_bucket": int64(1), "b_bucket": int64(0), "c_bucket": int64(0)},
tags{bucketLeftTag: "0", bucketRightTag: "15.5"},
)
assertContainsTaggedField(
t,
acc,
"first_metric_name",
fields{"a_bucket": int64(1), "b_bucket": int64(0), "c_bucket": int64(0)},
tags{bucketLeftTag: "15.5", bucketRightTag: "20"},
)
assertContainsTaggedField(
t,
acc,
"first_metric_name",
fields{"a_bucket": int64(0), "b_bucket": int64(0), "c_bucket": int64(0)},
tags{bucketLeftTag: "20", bucketRightTag: "30"},
)
assertContainsTaggedField(
t,
acc,
"first_metric_name",
fields{"a_bucket": int64(0), "b_bucket": int64(1), "c_bucket": int64(1)},
tags{bucketLeftTag: "30", bucketRightTag: "40"},
)
assertContainsTaggedField(
t,
acc,
"first_metric_name",
fields{"a_bucket": int64(0), "b_bucket": int64(0), "c_bucket": int64(0)},
tags{bucketLeftTag: "40", bucketRightTag: bucketPosInf},
)
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketLeftTag: bucketNegInf, bucketRightTag: "0"}) assertContainsTaggedField(
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketLeftTag: "0", bucketRightTag: "4"}) t,
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketLeftTag: "4", bucketRightTag: "10"}) acc,
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketLeftTag: "10", bucketRightTag: "23"}) "second_metric_name",
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketLeftTag: "23", bucketRightTag: "30"}) fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(1), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketLeftTag: "30", bucketRightTag: bucketPosInf}) tags{bucketLeftTag: bucketNegInf, bucketRightTag: "0"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketLeftTag: "0", bucketRightTag: "4"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketLeftTag: "4", bucketRightTag: "10"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketLeftTag: "10", bucketRightTag: "23"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketLeftTag: "23", bucketRightTag: "30"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(1), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketLeftTag: "30", bucketRightTag: bucketPosInf},
)
} }
// TestHistogramWithTwoPeriodsAndAllFields tests two metrics getting added with a push/reset in between (simulates // TestHistogramWithTwoPeriodsAndAllFields tests two metrics getting added with a push/reset in between (simulates
@ -266,7 +392,13 @@ func TestHistogramWithTwoPeriodsAndAllFields(t *testing.T) {
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketRightTag: "20"}) assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketRightTag: "20"})
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketRightTag: "30"}) assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(0), "c_bucket": int64(0)}, tags{bucketRightTag: "30"})
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(1), "c_bucket": int64(1)}, tags{bucketRightTag: "40"}) assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(1), "c_bucket": int64(1)}, tags{bucketRightTag: "40"})
assertContainsTaggedField(t, acc, "first_metric_name", fields{"a_bucket": int64(2), "b_bucket": int64(1), "c_bucket": int64(1)}, tags{bucketRightTag: bucketPosInf}) assertContainsTaggedField(
t,
acc,
"first_metric_name",
fields{"a_bucket": int64(2), "b_bucket": int64(1), "c_bucket": int64(1)},
tags{bucketRightTag: bucketPosInf},
)
} }
// TestWrongBucketsOrder tests the calling panic with incorrect order of buckets // TestWrongBucketsOrder tests the calling panic with incorrect order of buckets
@ -310,12 +442,48 @@ func TestHistogramMetricExpiration(t *testing.T) {
histogram.Push(acc) histogram.Push(acc)
require.Len(t, acc.Metrics, 6, "Incorrect number of metrics") require.Len(t, acc.Metrics, 6, "Incorrect number of metrics")
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketRightTag: "0"}) assertContainsTaggedField(
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketRightTag: "4"}) t,
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketRightTag: "10"}) acc,
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketRightTag: "23"}) "second_metric_name",
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketRightTag: "30"}) fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
assertContainsTaggedField(t, acc, "second_metric_name", fields{"a_bucket": int64(1), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)}, tags{bucketRightTag: bucketPosInf}) tags{bucketRightTag: "0"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketRightTag: "4"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketRightTag: "10"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketRightTag: "23"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(0), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketRightTag: "30"},
)
assertContainsTaggedField(
t,
acc,
"second_metric_name",
fields{"a_bucket": int64(1), "ignoreme_bucket": int64(0), "andme_bucket": int64(0)},
tags{bucketRightTag: bucketPosInf},
)
} }
// assertContainsTaggedField is help functions to test histogram data // assertContainsTaggedField is help functions to test histogram data