diff --git a/CHANGELOG.md b/CHANGELOG.md index ebd9ee088..0f2439332 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,7 @@ should now look like: - [#1289](https://github.com/influxdata/telegraf/pull/1289): webhooks input plugin. Thanks @francois2metz and @cduez! - [#1247](https://github.com/influxdata/telegraf/pull/1247): rollbar webhook plugin. +- [#1402](https://github.com/influxdata/telegraf/pull/1402): docker-machine/boot2docker no longer required for unit tests. ### Bugfixes diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6792abaa4..f02f109fd 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -114,7 +114,7 @@ creating the `Parser` object. You should also add the following to your SampleConfig() return: ```toml - ## Data format to consume. + ## Data format to consume. ## Each data format has it's own unique set of configuration options, read ## more about them here: ## https://github.com/influxdata/telegraf/blob/master/docs/DATA_FORMATS_INPUT.md @@ -244,7 +244,7 @@ instantiating and creating the `Serializer` object. You should also add the following to your SampleConfig() return: ```toml - ## Data format to output. + ## Data format to output. ## Each data format has it's own unique set of configuration options, read ## more about them here: ## https://github.com/influxdata/telegraf/blob/master/docs/DATA_FORMATS_OUTPUT.md @@ -290,10 +290,6 @@ To execute Telegraf tests follow these simple steps: instructions - execute `make test` -**OSX users**: you will need to install `boot2docker` or `docker-machine`. -The Makefile will assume that you have a `docker-machine` box called `default` to -get the IP address. - ### Unit test troubleshooting Try cleaning up your test environment by executing `make docker-kill` and diff --git a/Makefile b/Makefile index e2e87723f..816c93cf1 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,3 @@ -UNAME := $(shell sh -c 'uname') VERSION := $(shell sh -c 'git describe --always --tags') ifdef GOBIN PATH := $(GOBIN):$(PATH) @@ -46,20 +45,11 @@ prepare-windows: # Run all docker containers necessary for unit tests docker-run: -ifeq ($(UNAME), Darwin) - docker run --name kafka \ - -e ADVERTISED_HOST=$(shell sh -c 'boot2docker ip || docker-machine ip default') \ - -e ADVERTISED_PORT=9092 \ - -p "2181:2181" -p "9092:9092" \ - -d spotify/kafka -endif -ifeq ($(UNAME), Linux) docker run --name kafka \ -e ADVERTISED_HOST=localhost \ -e ADVERTISED_PORT=9092 \ -p "2181:2181" -p "9092:9092" \ -d spotify/kafka -endif docker run --name mysql -p "3306:3306" -e MYSQL_ALLOW_EMPTY_PASSWORD=yes -d mysql docker run --name memcached -p "11211:11211" -d memcached docker run --name postgres -p "5432:5432" -d postgres diff --git a/plugins/inputs/kafka_consumer/README.md b/plugins/inputs/kafka_consumer/README.md index f5f6a359e..afdb51e32 100644 --- a/plugins/inputs/kafka_consumer/README.md +++ b/plugins/inputs/kafka_consumer/README.md @@ -22,7 +22,7 @@ from the same topic in parallel. ## Offset (must be either "oldest" or "newest") offset = "oldest" - ## Data format to consume. + ## Data format to consume. ## Each data format has it's own unique set of configuration options, read ## more about them here: @@ -32,11 +32,5 @@ from the same topic in parallel. ## Testing -Running integration tests requires running Zookeeper & Kafka. The following -commands assume you're on OS X & using [boot2docker](http://boot2docker.io/) or docker-machine through [Docker Toolbox](https://www.docker.com/docker-toolbox). - -To start Kafka & Zookeeper: - -``` -docker run -d -p 2181:2181 -p 9092:9092 --env ADVERTISED_HOST=`boot2docker ip || docker-machine ip ` --env ADVERTISED_PORT=9092 spotify/kafka -``` +Running integration tests requires running Zookeeper & Kafka. See Makefile +for kafka container command.