Dynatrace Output: change handling of monotonic counters (#8159)

plugins/outputs/dynatrace/README.md

@@ -37,6 +37,7 @@ You will also need to configure an API token for secure access. Find out how to
 
 ## Requirements
 
+You will either need a Dynatrace OneAgent (version 1.201 or higher) installed on the same host as Telegraf; or a Dynatrace environment with version 1.202 or higher. Monotonic counters (e.g. diskio.reads, system.uptime) require release 208 or later.
 You will either need a Dynatrace OneAgent (version 1.201 or higher) installed on the same host as Telegraf; or a Dynatrace environment with version 1.202 or higher  
 
 ## Limitations

plugins/outputs/dynatrace/dynatrace.go

@@ -3,10 +3,6 @@ package dynatrace
 import (
 	"bytes"
 	"fmt"
-	"github.com/influxdata/telegraf"
-	"github.com/influxdata/telegraf/internal"
-	"github.com/influxdata/telegraf/plugins/common/tls"
-	"github.com/influxdata/telegraf/plugins/outputs"
 	"io/ioutil"
 	"math"
 	"net/http"
@@ -15,6 +11,11 @@ import (
 	"strconv"
 	"strings"
 	"time"
+
+	"github.com/influxdata/telegraf"
+	"github.com/influxdata/telegraf/internal"
+	"github.com/influxdata/telegraf/plugins/common/tls"
+	"github.com/influxdata/telegraf/plugins/outputs"
 )
 
 const (
@@ -22,11 +23,14 @@ const (
 )
 
 var (
-	reNameAllowedCharList = regexp.MustCompile("[^A-Za-z0-9.]+")
+	reNameAllowedCharList = regexp.MustCompile("[^A-Za-z0-9.-]+")
 	maxDimKeyLen          = 100
 	maxMetricKeyLen       = 250
 )
 
+var counts map[string]string
+var sent = 0
+
 // Dynatrace Configuration for the Dynatrace output plugin
 type Dynatrace struct {
 	URL      string            `toml:"url"`
@@ -188,16 +192,31 @@ func (d *Dynatrace) Write(metrics []telegraf.Metric) error {
 				if err != nil {
 					continue
 				}
-				fmt.Fprintf(&buf, "%s", metricID)
+				// write metric id,tags and value
-				// add the tag string
+				switch metric.Type() {
-				fmt.Fprintf(&buf, "%s", tagb.String())
+				case telegraf.Counter:
-
+					if lastvalue, ok := counts[metricID+tagb.String()]; ok {
-				// write measured value
+						// only send a counter if a lastvalue is found in the map
-				fmt.Fprintf(&buf, " %v\n", value)
+						// if last value is found we can calc and send the delta value
+						if v, err := strconv.ParseFloat(lastvalue, 32); err == nil {
+							if v2, err := strconv.ParseFloat(value, 32); err == nil {
+								fmt.Fprintf(&buf, "%s%s count,delta=%f\n", metricID, tagb.String(), v2-v)
+							}
+						}
+					}
+					// put the current value into the map as last value
+					counts[metricID+tagb.String()] = value
+				default:
+					fmt.Fprintf(&buf, "%s%s %v\n", metricID, tagb.String(), value)
+				}
 			}
 		}
 	}
-
+	sent++
+	// in typical interval of 10s, we will clean the counter state once in 24h which is 8640 iterations
+	if sent%8640 == 0 {
+		counts = make(map[string]string)
+	}
 	return d.send(buf.Bytes())
 }
 
@@ -240,6 +259,7 @@ func (d *Dynatrace) send(msg []byte) error {
 }
 
 func (d *Dynatrace) Init() error {
+	counts = make(map[string]string)
 	if len(d.URL) == 0 {
 		d.Log.Infof("Dynatrace URL is empty, defaulting to OneAgent metrics interface")
 		d.URL = oneAgentMetricsUrl