CL-Softwares
/
telegraf
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(inputs.mongodb): actually start plugin correctly (#11849)

This commit is contained in:
Joshua Powers 2022-09-21 13:05:01 -06:00 committed by GitHub
parent d091a59e66
commit f899eb5cde
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/inputs/mongodb/mongodb.go
View File

@ -94,7 +94,7 @@ func (m *MongoDB) Init() error {
} }
// Start runs after init and setup mongodb connections // Start runs after init and setup mongodb connections
func (m *MongoDB) Start() error { func (m *MongoDB) Start(telegraf.Accumulator) error {
for _, connURL := range m.Servers { for _, connURL := range m.Servers {
if !strings.HasPrefix(connURL, "mongodb://") && !strings.HasPrefix(connURL, "mongodb+srv://") { if !strings.HasPrefix(connURL, "mongodb://") && !strings.HasPrefix(connURL, "mongodb+srv://") {
// Preserve backwards compatibility for hostnames without a // Preserve backwards compatibility for hostnames without a
@ -144,6 +144,8 @@ func (m *MongoDB) Start() error {
return nil return nil
} }
func (m *MongoDB) Stop() {}
// Reads stats from all configured servers accumulates stats. // Reads stats from all configured servers accumulates stats.
// Returns one of the errors encountered while gather stats (if any). // Returns one of the errors encountered while gather stats (if any).
func (m *MongoDB) Gather(acc telegraf.Accumulator) error { func (m *MongoDB) Gather(acc telegraf.Accumulator) error {

17
plugins/inputs/mongodb/mongodb_server_test.go
View File

@ -47,7 +47,8 @@ func TestGetDefaultTagsIntegration(t *testing.T) {
} }
err := m.Init() err := m.Init()
require.NoError(t, err) require.NoError(t, err)
err = m.Start() var acc testutil.Accumulator
err = m.Start(&acc)
require.NoError(t, err) require.NoError(t, err)
server := m.clients[0] server := m.clients[0]
@ -84,12 +85,12 @@ func TestAddDefaultStatsIntegration(t *testing.T) {
} }
err := m.Init() err := m.Init()
require.NoError(t, err) require.NoError(t, err)
err = m.Start() var acc testutil.Accumulator
err = m.Start(&acc)
require.NoError(t, err) require.NoError(t, err)
server := m.clients[0] server := m.clients[0]
var acc testutil.Accumulator
err = server.gatherData(&acc, false, true, true, true, []string{"local"}) err = server.gatherData(&acc, false, true, true, true, []string{"local"})
require.NoError(t, err) require.NoError(t, err)
@ -115,10 +116,10 @@ func TestSkipBehaviorIntegration(t *testing.T) {
m.DisconnectedServersBehavior = "skip" m.DisconnectedServersBehavior = "skip"
err := m.Init() err := m.Init()
require.NoError(t, err) require.NoError(t, err)
err = m.Start() var acc testutil.Accumulator
err = m.Start(&acc)
require.NoError(t, err) require.NoError(t, err)
var acc testutil.Accumulator
err = m.Gather(&acc) err = m.Gather(&acc)
require.NoError(t, err) require.NoError(t, err)
require.NotContains(t, m.Log.(*testutil.CaptureLogger).LastError, "failed to gather data: ") require.NotContains(t, m.Log.(*testutil.CaptureLogger).LastError, "failed to gather data: ")
@ -136,16 +137,16 @@ func TestErrorBehaviorIntegration(t *testing.T) {
err := m.Init() err := m.Init()
require.NoError(t, err) require.NoError(t, err)
err = m.Start() var acc testutil.Accumulator
err = m.Start(&acc)
require.Error(t, err) require.Error(t, err)
// set to skip to bypass start error // set to skip to bypass start error
m.DisconnectedServersBehavior = "skip" m.DisconnectedServersBehavior = "skip"
err = m.Start() err = m.Start(&acc)
require.NoError(t, err) require.NoError(t, err)
m.DisconnectedServersBehavior = "error" m.DisconnectedServersBehavior = "error"
var acc testutil.Accumulator
err = m.Gather(&acc) err = m.Gather(&acc)
require.NoError(t, err) require.NoError(t, err)
require.Contains(t, m.Log.(*testutil.CaptureLogger).LastError, "failed to gather data: ") require.Contains(t, m.Log.(*testutil.CaptureLogger).LastError, "failed to gather data: ")