CL-Softwares
/
telegraf
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: muting tests for udp_listener (#9578)

This commit is contained in:
Sebastian Spaink 2021-08-05 10:59:51 -05:00 committed by GitHub
parent 249bcd25d5
commit fa77d2fb07
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 169 additions and 181 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

350
plugins/inputs/udp_listener/udp_listener_test.go
View File

@ -1,213 +1,201 @@
package udp_listener package udp_listener
import ( // This plugin will become officially deprecated in 2.0
"bufio" // These tests have been randomly failing the nightly tests, can't remove plugin until breaking changes are allowed to be merged
"bytes" // See this issue for more information: https://github.com/influxdata/telegraf/issues/9478
"fmt"
"io/ioutil"
"log"
"net"
"os"
"strings"
"testing"
"github.com/influxdata/telegraf/plugins/parsers" // const (
"github.com/influxdata/telegraf/testutil" // testMsg = "cpu_load_short,host=server01 value=12.0 1422568543702900257\n"
"github.com/stretchr/testify/require"
)
const ( // testMsgs = `
testMsg = "cpu_load_short,host=server01 value=12.0 1422568543702900257\n" // cpu_load_short,host=server02 value=12.0 1422568543702900257
// cpu_load_short,host=server03 value=12.0 1422568543702900257
// cpu_load_short,host=server04 value=12.0 1422568543702900257
// cpu_load_short,host=server05 value=12.0 1422568543702900257
// cpu_load_short,host=server06 value=12.0 1422568543702900257
// `
// )
testMsgs = ` // func newTestUDPListener() (*UDPListener, chan []byte) {
cpu_load_short,host=server02 value=12.0 1422568543702900257 // in := make(chan []byte, 1500)
cpu_load_short,host=server03 value=12.0 1422568543702900257 // listener := &UDPListener{
cpu_load_short,host=server04 value=12.0 1422568543702900257 // Log: testutil.Logger{},
cpu_load_short,host=server05 value=12.0 1422568543702900257 // ServiceAddress: ":8125",
cpu_load_short,host=server06 value=12.0 1422568543702900257 // AllowedPendingMessages: 10000,
` // in: in,
) // done: make(chan struct{}),
func newTestUDPListener() (*UDPListener, chan []byte) {
in := make(chan []byte, 1500)
listener := &UDPListener{
Log: testutil.Logger{},
ServiceAddress: ":8125",
AllowedPendingMessages: 10000,
in: in,
done: make(chan struct{}),
}
return listener, in
}
// func TestHighTrafficUDP(t *testing.T) {
// listener := UDPListener{
// ServiceAddress: ":8126",
// AllowedPendingMessages: 100000,
// } // }
// var err error // return listener, in
// listener.parser, err = parsers.NewInfluxParser()
// require.NoError(t, err)
// acc := &testutil.Accumulator{}
// // send multiple messages to socket
// err = listener.Start(acc)
// require.NoError(t, err)
// conn, err := net.Dial("udp", "127.0.0.1:8126")
// require.NoError(t, err)
// mlen := int64(len(testMsgs))
// var sent int64
// for i := 0; i < 20000; i++ {
// for sent > listener.BytesRecv.Get()+32000 {
// // more than 32kb sitting in OS buffer, let it drain
// runtime.Gosched()
// }
// conn.Write([]byte(testMsgs))
// sent += mlen
// }
// for sent > listener.BytesRecv.Get() {
// runtime.Gosched()
// }
// for len(listener.in) > 0 {
// runtime.Gosched()
// }
// listener.Stop()
// assert.Equal(t, uint64(100000), acc.NMetrics())
// } // }
func TestConnectUDP(t *testing.T) { // // func TestHighTrafficUDP(t *testing.T) {
listener := UDPListener{ // // listener := UDPListener{
Log: testutil.Logger{}, // // ServiceAddress: ":8126",
ServiceAddress: ":8127", // // AllowedPendingMessages: 100000,
AllowedPendingMessages: 10000, // // }
} // // var err error
listener.parser, _ = parsers.NewInfluxParser() // // listener.parser, err = parsers.NewInfluxParser()
// // require.NoError(t, err)
// // acc := &testutil.Accumulator{}
acc := &testutil.Accumulator{} // // // send multiple messages to socket
require.NoError(t, listener.Start(acc)) // // err = listener.Start(acc)
defer listener.Stop() // // require.NoError(t, err)
conn, err := net.Dial("udp", "127.0.0.1:8127") // // conn, err := net.Dial("udp", "127.0.0.1:8126")
require.NoError(t, err) // // require.NoError(t, err)
// // mlen := int64(len(testMsgs))
// // var sent int64
// // for i := 0; i < 20000; i++ {
// // for sent > listener.BytesRecv.Get()+32000 {
// // // more than 32kb sitting in OS buffer, let it drain
// // runtime.Gosched()
// // }
// // conn.Write([]byte(testMsgs))
// // sent += mlen
// // }
// // for sent > listener.BytesRecv.Get() {
// // runtime.Gosched()
// // }
// // for len(listener.in) > 0 {
// // runtime.Gosched()
// // }
// // listener.Stop()
// send single message to socket // // assert.Equal(t, uint64(100000), acc.NMetrics())
_, err = fmt.Fprint(conn, testMsg) // // }
require.NoError(t, err)
acc.Wait(1)
acc.AssertContainsTaggedFields(t, "cpu_load_short",
map[string]interface{}{"value": float64(12)},
map[string]string{"host": "server01"},
)
// send multiple messages to socket // func TestConnectUDP(t *testing.T) {
_, err = fmt.Fprint(conn, testMsgs) // listener := UDPListener{
require.NoError(t, err) // Log: testutil.Logger{},
acc.Wait(6) // ServiceAddress: ":8127",
hostTags := []string{"server02", "server03", // AllowedPendingMessages: 10000,
"server04", "server05", "server06"} // }
for _, hostTag := range hostTags { // listener.parser, _ = parsers.NewInfluxParser()
acc.AssertContainsTaggedFields(t, "cpu_load_short",
map[string]interface{}{"value": float64(12)},
map[string]string{"host": hostTag},
)
}
}
func TestRunParser(t *testing.T) { // acc := &testutil.Accumulator{}
log.SetOutput(ioutil.Discard) // require.NoError(t, listener.Start(acc))
var testmsg = []byte("cpu_load_short,host=server01 value=12.0 1422568543702900257\n") // defer listener.Stop()
listener, in := newTestUDPListener() // conn, err := net.Dial("udp", "127.0.0.1:8127")
acc := testutil.Accumulator{} // require.NoError(t, err)
listener.acc = &acc
defer close(listener.done)
listener.parser, _ = parsers.NewInfluxParser() // // send single message to socket
listener.wg.Add(1) // _, err = fmt.Fprint(conn, testMsg)
go listener.udpParser() // require.NoError(t, err)
// acc.Wait(1)
// acc.AssertContainsTaggedFields(t, "cpu_load_short",
// map[string]interface{}{"value": float64(12)},
// map[string]string{"host": "server01"},
// )
in <- testmsg // // send multiple messages to socket
require.NoError(t, listener.Gather(&acc)) // _, err = fmt.Fprint(conn, testMsgs)
// require.NoError(t, err)
// acc.Wait(6)
// hostTags := []string{"server02", "server03",
// "server04", "server05", "server06"}
// for _, hostTag := range hostTags {
// acc.AssertContainsTaggedFields(t, "cpu_load_short",
// map[string]interface{}{"value": float64(12)},
// map[string]string{"host": hostTag},
// )
// }
// }
acc.Wait(1) // func TestRunParser(t *testing.T) {
acc.AssertContainsTaggedFields(t, "cpu_load_short", // log.SetOutput(ioutil.Discard)
map[string]interface{}{"value": float64(12)}, // var testmsg = []byte("cpu_load_short,host=server01 value=12.0 1422568543702900257\n")
map[string]string{"host": "server01"},
)
}
func TestRunParserInvalidMsg(_ *testing.T) { // listener, in := newTestUDPListener()
log.SetOutput(ioutil.Discard) // acc := testutil.Accumulator{}
var testmsg = []byte("cpu_load_short") // listener.acc = &acc
// defer close(listener.done)
listener, in := newTestUDPListener() // listener.parser, _ = parsers.NewInfluxParser()
acc := testutil.Accumulator{} // listener.wg.Add(1)
listener.acc = &acc // go listener.udpParser()
defer close(listener.done)
listener.parser, _ = parsers.NewInfluxParser() // in <- testmsg
listener.wg.Add(1) // require.NoError(t, listener.Gather(&acc))
go listener.udpParser()
buf := bytes.NewBuffer(nil) // acc.Wait(1)
log.SetOutput(buf) // acc.AssertContainsTaggedFields(t, "cpu_load_short",
defer log.SetOutput(os.Stderr) // map[string]interface{}{"value": float64(12)},
in <- testmsg // map[string]string{"host": "server01"},
// )
// }
scnr := bufio.NewScanner(buf) // func TestRunParserInvalidMsg(_ *testing.T) {
for scnr.Scan() { // log.SetOutput(ioutil.Discard)
if strings.Contains(scnr.Text(), fmt.Sprintf(malformedwarn, 1)) { // var testmsg = []byte("cpu_load_short")
break
}
}
}
func TestRunParserGraphiteMsg(t *testing.T) { // listener, in := newTestUDPListener()
log.SetOutput(ioutil.Discard) // acc := testutil.Accumulator{}
var testmsg = []byte("cpu.load.graphite 12 1454780029") // listener.acc = &acc
// defer close(listener.done)
listener, in := newTestUDPListener() // listener.parser, _ = parsers.NewInfluxParser()
acc := testutil.Accumulator{} // listener.wg.Add(1)
listener.acc = &acc // go listener.udpParser()
defer close(listener.done)
listener.parser, _ = parsers.NewGraphiteParser("_", []string{}, nil) // buf := bytes.NewBuffer(nil)
listener.wg.Add(1) // log.SetOutput(buf)
go listener.udpParser() // defer log.SetOutput(os.Stderr)
// in <- testmsg
in <- testmsg // scnr := bufio.NewScanner(buf)
require.NoError(t, listener.Gather(&acc)) // for scnr.Scan() {
// if strings.Contains(scnr.Text(), fmt.Sprintf(malformedwarn, 1)) {
// break
// }
// }
// }
acc.Wait(1) // func TestRunParserGraphiteMsg(t *testing.T) {
acc.AssertContainsFields(t, "cpu_load_graphite", // log.SetOutput(ioutil.Discard)
map[string]interface{}{"value": float64(12)}) // var testmsg = []byte("cpu.load.graphite 12 1454780029")
}
func TestRunParserJSONMsg(t *testing.T) { // listener, in := newTestUDPListener()
log.SetOutput(ioutil.Discard) // acc := testutil.Accumulator{}
var testmsg = []byte("{\"a\": 5, \"b\": {\"c\": 6}}\n") // listener.acc = &acc
// defer close(listener.done)
listener, in := newTestUDPListener() // listener.parser, _ = parsers.NewGraphiteParser("_", []string{}, nil)
acc := testutil.Accumulator{} // listener.wg.Add(1)
listener.acc = &acc // go listener.udpParser()
defer close(listener.done)
listener.parser, _ = parsers.NewParser(&parsers.Config{ // in <- testmsg
DataFormat: "json", // require.NoError(t, listener.Gather(&acc))
MetricName: "udp_json_test",
})
listener.wg.Add(1)
go listener.udpParser()
in <- testmsg // acc.Wait(1)
require.NoError(t, listener.Gather(&acc)) // acc.AssertContainsFields(t, "cpu_load_graphite",
// map[string]interface{}{"value": float64(12)})
// }
acc.Wait(1) // func TestRunParserJSONMsg(t *testing.T) {
acc.AssertContainsFields(t, "udp_json_test", // log.SetOutput(ioutil.Discard)
map[string]interface{}{ // var testmsg = []byte("{\"a\": 5, \"b\": {\"c\": 6}}\n")
"a": float64(5),
"b_c": float64(6), // listener, in := newTestUDPListener()
}) // acc := testutil.Accumulator{}
} // listener.acc = &acc
// defer close(listener.done)
// listener.parser, _ = parsers.NewParser(&parsers.Config{
// DataFormat: "json",
// MetricName: "udp_json_test",
// })
// listener.wg.Add(1)
// go listener.udpParser()
// in <- testmsg
// require.NoError(t, listener.Gather(&acc))
// acc.Wait(1)
// acc.AssertContainsFields(t, "udp_json_test",
// map[string]interface{}{
// "a": float64(5),
// "b_c": float64(6),
// })
// }