CL-Softwares
/
telegraf
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore(inputs.powerdns): Don't run flaky test on Windows (#11982)

This commit is contained in:
Sebastian Spaink 2022-10-11 12:44:49 -05:00 committed by GitHub
parent b477573359
commit fae64e2a63
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 52 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
plugins/inputs/powerdns/powerdns_linux_test.go Normal file
View File

@ -0,0 +1,52 @@
//go:build !windows
package powerdns
import (
"fmt"
"net"
"os"
"path/filepath"
"testing"
"github.com/influxdata/telegraf/testutil"
"github.com/stretchr/testify/require"
)
func TestPowerdnsGeneratesMetrics(t *testing.T) {
// We create a fake server to return test data
randomNumber := int64(5239846799706671610)
sockname := filepath.Join(os.TempDir(), fmt.Sprintf("pdns%d.controlsocket", randomNumber))
socket, err := net.Listen("unix", sockname)
if err != nil {
t.Fatal("Cannot initialize server on port ")
}
defer socket.Close()
s := statServer{}
go s.serverSocket(socket)
p := &Powerdns{
UnixSockets: []string{sockname},
}
var acc testutil.Accumulator
err = acc.GatherError(p.Gather)
require.NoError(t, err)
intMetrics := []string{"corrupt-packets", "deferred-cache-inserts",
"deferred-cache-lookup", "dnsupdate-answers", "dnsupdate-changes",
"dnsupdate-queries", "dnsupdate-refused", "packetcache-hit",
"packetcache-miss", "packetcache-size", "query-cache-hit", "query-cache-miss",
"rd-queries", "recursing-answers", "recursing-questions",
"recursion-unanswered", "security-status", "servfail-packets", "signatures",
"tcp-answers", "tcp-queries", "timedout-packets", "udp-answers",
"udp-answers-bytes", "udp-do-queries", "udp-queries", "udp4-answers",
"udp4-queries", "udp6-answers", "udp6-queries", "key-cache-size", "latency",
"meta-cache-size", "qsize-q", "signature-cache-size", "sys-msec", "uptime", "user-msec"}
for _, metric := range intMetrics {
require.True(t, acc.HasInt64Field("powerdns", metric), metric)
}
}

43
plugins/inputs/powerdns/powerdns_test.go
View File

@ -1,14 +1,9 @@
package powerdns
import (
"fmt"
"net"
"os"
"path/filepath"
"testing"
"github.com/stretchr/testify/require"
"github.com/influxdata/telegraf/testutil"
)
@ -73,44 +68,6 @@ func (s statServer) serverSocket(l net.Listener) {
}
}
func TestPowerdnsGeneratesMetrics(t *testing.T) {
// We create a fake server to return test data
randomNumber := int64(5239846799706671610)
sockname := filepath.Join(os.TempDir(), fmt.Sprintf("pdns%d.controlsocket", randomNumber))
socket, err := net.Listen("unix", sockname)
if err != nil {
t.Fatal("Cannot initialize server on port ")
}
defer socket.Close()
s := statServer{}
go s.serverSocket(socket)
p := &Powerdns{
UnixSockets: []string{sockname},
}
var acc testutil.Accumulator
err = acc.GatherError(p.Gather)
require.NoError(t, err)
intMetrics := []string{"corrupt-packets", "deferred-cache-inserts",
"deferred-cache-lookup", "dnsupdate-answers", "dnsupdate-changes",
"dnsupdate-queries", "dnsupdate-refused", "packetcache-hit",
"packetcache-miss", "packetcache-size", "query-cache-hit", "query-cache-miss",
"rd-queries", "recursing-answers", "recursing-questions",
"recursion-unanswered", "security-status", "servfail-packets", "signatures",
"tcp-answers", "tcp-queries", "timedout-packets", "udp-answers",
"udp-answers-bytes", "udp-do-queries", "udp-queries", "udp4-answers",
"udp4-queries", "udp6-answers", "udp6-queries", "key-cache-size", "latency",
"meta-cache-size", "qsize-q", "signature-cache-size", "sys-msec", "uptime", "user-msec"}
for _, metric := range intMetrics {
require.True(t, acc.HasInt64Field("powerdns", metric), metric)
}
}
func TestPowerdnsParseMetrics(t *testing.T) {
p := &Powerdns{
Log: testutil.Logger{},