Commit Graph

153 Commits

Author SHA1 Message Date
Jean-Sébastien Dupuy 374662be07
test: add sqlserver plugin integration tests (#9943)
* Adding integration tests for AzureSQLDBResourceStats.

* Adding azuresqlmanagedqueries_test.go

* Updated integration tests for sql managed instance queries.

* Updated integration tests for sql database queries.

* Updated integration tests for azure sql database queries

* Updated integration tests for azure sql managed instance queries

* Fixed lint issues with make fmt.

Co-authored-by: yannick <yabromba@microsoft.com>
2021-10-25 09:35:12 -06:00
Mark Wilkinson - m82labs 57ecd1d21b
Worktable workfile stats (#8587) 2021-07-26 20:55:03 -05:00
Madhushree Sreenivasa 2267733a04
Provide detailed error message in telegraf log (#9466) 2021-07-13 15:08:41 -06:00
reimda 537ac63c68
Sqlserver input: require authentication method to be specified (#9388) 2021-07-07 13:09:52 -06:00
Giovanni Luisotto ae7d31996b
SQL Server - SQL Requests - added s.[login_name] (#8351) 2021-05-13 23:59:02 -05:00
Giovanni Luisotto 8b9883e2ec
SQL Server - sqlServerRingBufferCPU - removed whitespaces (#9130)
### Required for all PRs:

- [ ] Updated associated README.md.
- [ ] Wrote appropriate unit tests.

Removed a pair of whitespace chars from the **sqlServerRingBufferCPU** SQL statement and added some formatting.
This query exists only for the on-prem version of SQL Server (`database_type = "SQLServer"`)

If you were unlucky enough to have some SQL 2008 the query wouldn't work as the whitespace char is not allowed inside the statement.
2021-05-11 16:08:25 -05:00
Avinash Nigam f39d68d1fa
SQL Server input plugin - Enable Azure Active Directory (AAD) authentication support (#8822)
### Required for all PRs:

- [ ] Associated README.md updated.
- [ ] Has appropriate unit tests.

Associated to feature request - [Azure Active Directory (AAD) authentication support in SQL Server input plugin](https://github.com/influxdata/telegraf/issues/8808#issue-801695311)

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
2021-04-21 11:02:07 -05:00
Sven Rebhan 8e7da355b3
Linter fixes (unhandled errors) -- Part 1 (#8992) 2021-04-08 11:43:39 -05:00
Mattias Jiderhamn 871447b22c
input/sqlserver: Add service and save connection pools (#8596) 2021-03-29 11:22:36 -04:00
Samantha Wang 5423e7a049
update: inputs.sqlserver support version in readme (#9040) 2021-03-24 13:42:58 -07:00
Paweł Żak 5de640b855
Linter fixes - unconvert, revive:empty-lines, revive:var-naming, revive:unused-parameter (#9036)
Co-authored-by: Pawel Zak <Pawel Zak>
2021-03-24 11:27:46 -04:00
Cláudio Silva 9aaaf72a96
SQLServer - Fixes sqlserver_process_cpu calculation (#8549) 2021-03-23 17:45:27 -04:00
Paweł Żak 38c61c07ef
Revive fixes - part 4: (#8981)
empty-lines

Co-authored-by: Pawel Zak <Pawel Zak>
2021-03-12 14:21:51 -06:00
Connor Quagliana 30e189df16
Add an optional health metric for the sqlserver input plugin (#8544) 2021-03-11 16:07:38 -05:00
Madhushree Sreenivasa 35b75e959c
Filter data out from system databases for Azure SQL DB only (#8849)
* Excluding data from system databases like msdb,model which are not
relevant for monitoring in Azure SQL

Please enter the commit message for your changes. Lines starting

* Addressing review comments to handle null scenarios
2021-03-11 15:04:09 -06:00
Avinash Nigam cf9ae34d03
SqlServer - fix for default server list (#8655) 2021-03-02 14:55:28 -05:00
Paweł Żak 8a6907a186
Revive fixes - part 3 (#8872)
* * Revive fixes regarding following set of rules: [rule.var-naming]
2021-03-01 16:04:35 -05:00
Avinash Nigam b362ee4665
Bug Fix - SQL Server HADR queries for SQL Versions (#8833) 2021-02-26 13:59:29 -05:00
Avinash Nigam 2372db9028
SQL Perfmon counters - synced queries from v2 to all db types (#8393) 2021-02-19 15:59:26 -05:00
Helen Weller d41569caed
Integration test audit (#8725) 2021-01-26 11:06:12 -07:00
bhsu-ms 752a4b77e1
Added tags for monitoring readable secondaries for Azure SQL MI (#8369) 2020-12-08 15:42:31 -05:00
Avinash Nigam e687cd7a5f
SQL Server HA/DR Availability Group queries (#8379) 2020-12-08 15:40:11 -05:00
bhsu-ms f7d94430d2
Added is_primary_replica for monitoring readable secondaries for Azure SQL DB (#8368) 2020-12-03 11:07:08 -05:00
Igor Kuchmienko def6963b5e
sqlAzureMIRequests - remove duplicate column [session_db_name] (#8462) 2020-12-03 11:06:19 -05:00
Igor Kuchmienko a267570ae3
Add column measurement_db_type to output of all queries if not empty (#8464) 2020-12-03 11:05:43 -05:00
Igor Kuchmienko e28cccf201
Fix typo in column name (#8468) 2020-11-24 14:45:09 -05:00
Russ Savage dabea48a90
Fix minor typos in readmes (#8370) 2020-11-12 10:20:50 -07:00
Giovanni Luisotto 1939e58b68
On-prem fix for #8324 (#8356) 2020-11-03 11:04:24 -05:00
Giovanni Luisotto c5e04325ab
SQL Server Azure PerfCounters Fix (#8331) 2020-10-28 14:00:37 -04:00
Giovanni Luisotto 1313f2314f
SQL Server - PerformanceCounters - removed synthetic counters (#8325) 2020-10-27 15:19:49 -04:00
Giovanni Luisotto f14a50b511
SQL Server - server_properties added sql_version_desc (#8324) 2020-10-27 14:36:21 -04:00
Giovanni Luisotto f61457f87a
sqlAzureMIResourceStats - added sorting (#8286) 2020-10-20 10:17:17 -04:00
Giovanni Luisotto 1d6172bd2d
New sql server queries (on-prem) - refactoring and formatting (#8172) 2020-10-14 11:07:13 -04:00
Giovanni Luisotto d840448b65
New sql server queries (Azure) - refactoring and formatting (#8186)
* sqlAzureDBResourceStats - formatting & engine check
* sqlAzureDBResourceGovernance - formatting & engine check
* sqlAzureDBWaitStats - formatting and engine check
* sqlAzureDBDatabaseIO - formatting and engine check
* sqlAzureDBProperties - formatting and engine check
* sqlAzureDBProperties - fix [engine_edition]
* sqlAzureDBOsWaitStats - formatting and engine check
* sqlAzureDBOsWaitStats - fix DBMIRROR_QUEUE string
* sqlAzureDBMemoryClerks  - formatting and engine check
* sqlAzureDBRequests - formatting and engine check
* sqlAzureDBSchedulers - moved near other queries
* sqlAzureMIRequests - added [session_db_name]
* sqlAzureDBPerformanceCounters - formatting and engine check
* sqlAzureMIProperties - formatting and engine check
* sqlAzureMIResourceStats - formatting and engine check
* sqlAzureMIResourceGovernance - formatting and engine check
* sqlAzureMIDatabaseIO - formatting and engine check
* sqlAzureMIMemoryClerks - formatting and engine check
* sqlAzureMIOsWaitStats - formatting and engine check
* sqlAzureDBPerformanceCounters - fix check edition
* sqlAzureMIPerformanceCounters - formatting and engine check
* sqlAzureMIRequests - formatting and engine check
* sqlAzureMISchedulers - engine check
* Changed error msg to include DB_NAME
* removed DEADLOCK_PRIORITY from most queries
* sqlAzureDBSchedulers - added engineedition check
2020-10-07 11:56:13 -04:00
Giovanni Luisotto 88698a68d9
Fixed Query mapping (#8200) 2020-10-07 08:30:54 -06:00
Avinash Nigam bb5c65f5f3
Added more performance counters to SqlServer input plugin (#8120) 2020-09-24 10:09:51 -06:00
denzilribeiro f0c2c38931
Database_type config to Split up sql queries by engine type (#7934) 2020-09-08 17:36:23 -04:00
Giovanni Luisotto 211c2369aa
added new counter - Lock Timeouts (timeout > 0)/sec (#7808) 2020-08-10 11:08:26 -04:00
denzilribeiro 1874ab53cb
Fix incorrect Azure SQL DB server properties (#7715) 2020-06-24 10:34:00 -07:00
denzilribeiro dd3ff0e8b4
Add counter type to perfmon collector (#7712) 2020-06-23 11:44:08 -07:00
Giovanni Luisotto 5b84d3ba92
Remove trailing backslash management in sqlserver input (#7700)
Backslash removal on tags is performed by the influx serializer now.
2020-06-17 14:11:10 -07:00
Giovanni Luisotto c560aea5a9
Improve sqlserver input compatibility with older server versions (#7495) 2020-06-12 11:56:06 -07:00
Josh Soref f975b94404
Fix typos in sqlserver input (#7524) 2020-05-22 00:05:10 -07:00
denzilribeiro 5280023abe
Fix instance name resolution in performance counter query (#7526) 2020-05-20 16:55:37 -07:00
Giovanni Luisotto db0d950b3a
Add cpu query to sqlserver input (#7359) 2020-05-07 11:25:03 -07:00
Giovanni Luisotto 53c86890af
Rename measurement to sqlserver_volume_space (#7457) 2020-05-05 10:56:03 -07:00
Giovanni Luisotto 82c9f0f7f8
Trim instance tag in the sqlserver performance counters query (#7351) 2020-04-21 13:42:35 -07:00
Giovanni Luisotto c56596dec2
Sql Server - Disk Space Measurement (#7214) 2020-04-06 11:53:54 -04:00
denzilribeiro ccefc42711
Add OPTION RECOMPILE for perf reasons due to temp table (#7242) 2020-03-31 12:54:22 -07:00
Harshit Bansal a612a4d85f
Add option for explicitly including queries in sqlserver input plugin (#7150) 2020-03-16 13:46:42 -07:00
Giovanni Luisotto 20d45d651c
Fix schedulers query compatibility with pre SQL-2016 (#7144) 2020-03-16 13:36:31 -07:00
denzilribeiro 0a75dea70d
Add Database IO Tempdb per Azure DB and fix PerfmonV2 collection for on-prem (#7163) 2020-03-16 13:32:30 -07:00
Giovanni Luisotto 1601a06915
Fix several issues with DatabaseIO query in sqlserver input (#7103) 2020-03-10 12:44:54 -07:00
Giovanni Luisotto 413ca898be
Fix perf counters collection on named instances in sqlserver input (#7060) 2020-02-21 11:11:50 -08:00
denzilribeiro 1df88dd22b Add RBPEX stats collection, DBName for perfmon, proper type for resource stats (#6869) 2020-01-08 17:55:37 -08:00
Daniel Nelson 1498f8addf
Add cardinality tips to FAQ and sqlserver input (#6852) 2020-01-08 10:52:58 -08:00
Giovanni Luisotto 3d8940e69b Encode query hash fields as hex strings in sqlserver input (#6818) 2019-12-30 11:45:46 -08:00
chuckbarkertech 94fc769e0b Fix ServerProperty query stops working on Azure after failover (#6794) 2019-12-12 13:16:41 -08:00
Daniel Nelson 0e6500669a
Add missing ServerProperties query to sqlserver input docs (#6625) 2019-11-07 16:29:45 -08:00
Giovanni Luisotto ba579819a0 Add missing character replacement to sql_instance tag (#6610) 2019-11-05 11:56:48 -08:00
GeorgeJahad c26aeb871d Remove package level vars from sqlserver and mysql input plugins (#6468) 2019-10-04 12:18:34 -07:00
Mark Wilkinson - m82labs 68d11e01ab Add more performance counter metrics to sqlserver input (#6465) 2019-09-30 16:50:33 -07:00
GeorgeJahad e553341879 Update sqlserver docs for TLS connections (#6409) 2019-09-17 15:48:08 -07:00
denzilribeiro 109d1e1e15 Add support for collecting SQL Requests to identify waits and blocking (#6144) 2019-07-22 15:04:15 -07:00
denzilribeiro 329179c0ff Fix sql_instance tag with sqlserver managed instance (#6116) 2019-07-15 11:46:52 -07:00
denzilribeiro 149be55c64 Add improved support for Azure SQL Database (#6111) 2019-07-12 11:37:00 -07:00
Arno den Uijl adc32002da Fix sqlserver connection closing on error (#5897) 2019-05-22 13:13:19 -07:00
Daniel Nelson 9e0248898f
Disable results by row in azuredb query (#5467) 2019-02-25 10:54:19 -08:00
Phil Schwartz c8832a28c4 Set deadlock priority in sqlserver input (#5301) 2019-02-11 17:10:42 -08:00
Daniel Nelson efbc83c8b6
Document that sqlserver input requires SP3 2019-01-22 15:47:57 -08:00
Phil Schwartz 1c3acafc8f Fix arithmetic overflow in sqlserver input (#5261) 2019-01-08 14:13:14 -08:00
BoheeChoi1 cb9bacfede Add forwarded records to sqlserver input (#5177) 2018-12-27 13:18:29 -08:00
Mark Wilkinson - m82labs 503f3ce0a6 Remove storage calculation for non Azure managed instances and add server version (#5135)
- Removed the storage calculation for SQL Server instances that are NOT Azure
  Managed Instances, this reduces the time it takes to get this data on an
  instance with a lot of databases and/or database files.
- Added the SQL Server version back to the server properties query.
2018-12-13 11:42:35 -08:00
Tracy Boggiano 69f6612c2a Fix hardware_type may be truncated in sqlserver input (#4750) 2018-09-26 19:02:29 -07:00
Tracy Boggiano adf2668c1d Fix forwarded records and offline state in sqlserver input (#4730) 2018-09-21 12:18:27 -07:00
Mark Wilkinson - m82labs b43165f2d8 Improve Azure Managed Instance support + more in sqlserver input (#4642) 2018-09-11 18:47:30 -07:00
Tracy Boggiano 0785821a80 Add forwarded records to sqlserver input (#4571) 2018-08-23 16:59:21 -07:00
Mark Wilkinson - m82labs ff40da6019 Use explicit casts to avoid datatype issues (#3980) 2018-04-06 14:58:33 -07:00
Mark Wilkinson - m82labs a971ffb880 Remove host tag from Database IO v2 Query (#3953) 2018-03-30 13:22:24 -07:00
Mark Wilkinson - m82labs d7f279e3d3 Fix SQL Server 2008 compatibility (#3916)
* Fixed a bug in the performance counter query when run against SQL Server 2016 SP1-CU2. The performance counter DMV contains duplicate entries which are not handled by the query.

* Adding more stats related to workload groups.

* Adding new RG stats, removing "host" tag

* Removed workload group query

* Fixing some 2008 compat issues, removed the host field from the result set.

* Adding fixes for SQL Server 2008 compat around RG columns. Also converted perf counter query to support named instances.
2018-03-22 10:38:40 -07:00
dilshatm a6d366fb84 Fix collation difference in sqlserver input (#3786) 2018-03-07 14:16:17 -08:00
Mark Wilkinson - m82labs 42ccc9f324 Added additional SQL Server performance counters (#3770)
* Included system databases in server properties, added backup/restore throughput counter, error counters, and user settable counters.

* Added more resource governor counters.

* Added Target and Total Server Memory counters.

* Removed the c_type tag from the performance counters query, added more documentation instead.
2018-02-09 12:45:22 -08:00
Daniel Nelson 8c8c9200e7
Update sqlserver readme; enable query_version = 2 in default config
If unset, query_version is still treated as version 1 for compatibility.
2018-02-01 12:13:49 -08:00
Mark Wilkinson - m82labs 426360d61f Add new sql server output data model (#3618) 2018-02-01 11:50:26 -08:00
erayaslan a06ee58785 Use MAX() instead of SUM() for latency measurements in sqlserver (#3471) 2017-11-16 16:49:51 -08:00
Daniel Nelson 1f348037b7 Fix case sensitivity issue in sqlserver query (#3336) 2017-10-16 11:26:16 -07:00
Daniel Nelson 8e3ed96d6f Fix case sensitivity error in sqlserver input (#3287) 2017-10-02 17:15:34 -07:00
Mark Wilkinson - m82labs 1c5ebd4be3 Fix duplicate keys in perf counters sqlserver query (#3175) 2017-09-14 15:04:13 -07:00
Zack Zatkin-Gold dd537b3382 Fix telegraf example arguments (#2788)
Many of the examples provided within documentation are using a single
dash for the command line arguments, but the telegraf executable
explicitly has two dashes.

There are also some inconsistencies with the ordering of the command
line argument examples.  I've ordered them so that the examples will
show: config, config-directory, input-filter, test
2017-05-12 15:22:29 -07:00
ceseuron e2983383e4 Fixed sqlserver input to work with case sensitive server collation. (#2749)
Fixed a problem with sqlserver input where database properties are not returned by Telegraf when SQL Server has been set up with a case sensitive server-level collation.

* Added bugfix entry to CHANGELOG.md for sqlserver collation input fix.
2017-05-04 10:47:03 -07:00
Patrick Hemmer 06baf7cf78 use AddError everywhere (#2372) 2017-04-24 11:13:26 -07:00
Kebus1 734988d732 Fixed Bug 2077 SQL Server (#2212) 2017-01-13 13:47:47 +00:00
zensqlmonitor 817d696628 SQL Server plugin: Fix WaitStats issue (#1859)
Issue #1854
2016-10-06 14:21:14 +01:00
zensqlmonitor 573628dbdd Fix collation issue 2016-09-28 16:11:00 +01:00
Cameron Sparr 6dbbe65897 Remove Add() function from accumulator 2016-09-02 16:35:27 +01:00
Stian Øvrevåge 4b6f9b93dd Updated sqlserver.go - Added Rows/Logs max size (#1380)
I added Rows/Logs max size counters for tracking databases that do not have autogrowth enabled. The counters return numbers in 8KB pages since there are a few special values (such as -1 for no max size) that can't directly be multiplied by 8192 to get size in bytes.

Also added Rows/Logs size in 8KB pages for comparison from the same system table. Even though it returns the same size as sizes from sys.dm_io_virtual_file_stats which are already collected.
2016-06-22 14:39:35 +01:00
zensqlmonitor 93f5b8cc4a Fix datatype conversion 2016-04-23 09:14:04 +02:00
Balakrishnan ba06533c3e Fixed SQL Server Plugin issues #881 2016-03-17 18:01:19 -04:00
Cameron Sparr 8d2e5f0bda Seems to be a toml parse bug around triple pounds 2016-02-18 14:36:03 -07:00
Cameron Sparr fc7fa4b6c5 Cleanup comments and indentation in config file 2016-02-09 11:01:50 -07:00