Commit Graph

15 Commits

Author SHA1 Message Date
Paweł Żak 5661341813
chore: Enable filepathJoin checker for gocritic (#13758)
Co-authored-by: Pawel Zak <Pawel Zak>
2023-08-14 23:18:20 +02:00
Joshua Powers 9ede0b0c49
chore: Enable multi-os golanglint-ci (#13599) 2023-07-14 15:58:19 +02:00
Paweł Żak c76f319b84
chore: Remove `revive:unhandled-error` - `errcheck` is more flexible (#13008) 2023-04-03 07:19:43 -06:00
Paweł Żak d9d9cd4c0b
chore: fix linter findings for nolintlint part 1 (#12427) 2023-01-25 13:28:13 -07:00
Sven Rebhan 373966babe
feat(inputs.diskio): Allow selecting devices by ID (#11703) 2022-09-28 09:26:14 -05:00
Sven Rebhan 03b2daeb1b
Linter fixes (unhandled errors) -- Part 2 (#9122) 2021-04-22 16:08:03 -05:00
Paweł Żak 5de640b855
Linter fixes - unconvert, revive:empty-lines, revive:var-naming, revive:unused-parameter (#9036)
Co-authored-by: Pawel Zak <Pawel Zak>
2021-03-24 11:27:46 -04:00
Niels Huylebroeck e1a896ca12
Non systemd support with unittest (#8785) 2021-02-26 10:42:46 -05:00
Paweł Żak d9736d543f
Revive fixes - part 2 (#8835)
* Revive fixes regarding following set of rules:
[rule.if-return]
[rule.increment-decrement]
[rule.var-declaration]
[rule.package-comments]
[rule.receiver-naming]
[rule.unexported-return]
2021-02-16 18:19:50 -05:00
Jonathan Hurter 01e31e9d53 Invalidate diskio cache if the metadata mtime has changed (#6835) 2019-12-30 13:52:03 -08:00
Soulou 205de66dd6
[diskio] Force type of stat.Rdev uint64 for mipsle compatibility
For most platforms, stat.Rdev is already a uint64 so this is without any effect
for linux,mipsle, unix.Stat_t.Rdev is a uint32, but the way to compute major and minor doesn't change, casting the uint32 has no impact either
2019-03-21 12:00:20 +01:00
Soulou 2118fbe78a
Use unix.Major/unix.Minor instead of custom implementation 2019-03-15 14:36:56 +01:00
Soulou 92b01ab4f9
Fix how major and minor identifiers of block devices are read.
The current implementation assure that the major and the minor are
coded on one byte. But they are not:

```
brw-rw----  1 root disk    252, 290 Feb 25 11:36 dm-290
```

290 as minor in this example is over 1 byte.

So after wondering why all my devices iops weren't correctly stored,
I found out that several points were added for some disks. For `dm-290`
it was overriding `252:34`, instead of getting udev stats for `252:290`.

The solution is here:
https://sites.uclouvain.be/SystInfo/usr/include/sys/sysmacros.h.html

The implementation is directly taken from this, fixing my bug.
2019-03-11 01:31:30 +01:00
dbergmanskytap 6b5ddbbf66 Include DEVLINKS in available diskio udev properties (#5116) 2018-12-13 11:49:19 -08:00
Steve Domino 7b73b0db3a Moved system package inputs out to top level (#4406) 2018-07-11 16:43:49 -07:00