Commit Graph

57 Commits

Author SHA1 Message Date
Paweł Żak 990ffc7222
chore(linters): Fix findings found by testifylint: bool-compare (#14163) 2023-10-24 10:45:17 -06:00
Thomas Casteleyn 6a2f6f301f
chore: eliminate unnecessary use of quoted strings in printf (#12722) 2023-02-23 06:49:36 -07:00
Joshua Powers a586101d84
test(inputs.snmp): Use random port (#12464) 2023-01-12 18:30:04 +01:00
Thomas Casteleyn 25154e50fd
feat(inputs.snmp): convert enum values (#11872) 2022-11-28 08:01:18 -07:00
reimda 0dd99b2157
fix(inputs/snmp): switch new Reconnect method to be a value receiver (#11197) 2022-05-27 15:03:46 -06:00
Joshua Powers 02dd7c1752
test: actually skip flaky snmp test (#11199)
This test had a short skip added to it four years ago and a comment that
the test has random failures. While working on the integration tests,
which run all tests this test started showing up in the errors.

While the two asserts at the end could possibly be updated, it is worth
having someone look deeper into understanding why this change is
required.

In order to get integration tests running, this skips this test always.
2022-05-27 07:14:16 -06:00
Thomas Casteleyn 885444ab3e
fix(inputs/snmp): Reconnect TCP agents if needed (#11163) 2022-05-25 12:47:51 -06:00
Joshua Powers 0d18847f59
fix: check net.Listen() error in tests (#11093) 2022-05-16 13:37:53 -06:00
Sebastian Spaink b355be5ccb
feat: migrate input plugins to new sample config format (M-Z) (#10926) 2022-04-11 16:32:25 -05:00
reimda 77040ef4e9
fix: Add option to select translator (#10802) 2022-03-17 21:43:46 -06:00
Mya d18ff3407d
fix: ensure folders do not get loaded more than once (#10551) 2022-02-16 12:25:20 -07:00
Laurent Sesquès 457c98f4c2
fix: snmp input plugin errors if mibs folder doesn't exist (#10346) (#10354) 2022-01-11 15:17:05 -07:00
Joshua Powers 6a1442f1bc
fix: do not require networking during tests (#10321) 2021-12-21 13:44:10 -07:00
Mya 1e81d98fdd
fix: panic due to no module (#10303) 2021-12-20 13:40:00 -07:00
Mya 973ffba9fb
fix: check index before assignment (#10299) 2021-12-20 10:52:47 -07:00
Sven Rebhan 2d420fbd35
feat: Optimize locking for SNMP MIBs loading. (#10206) 2021-12-07 15:05:33 -07:00
Mya 7675ce6d19
refactor: snmp to use gosmi (#9518) 2021-11-30 15:47:50 -07:00
Paweł Żak 7aa6b533bd
fix: Linter fixes for plugins/inputs/[p-z]* (leftovers) (#10193)
Co-authored-by: Pawel Zak <Pawel Zak>
2021-11-30 13:31:10 -06:00
Paweł Żak 2a0c3059a1
fix: Linter fixes for plugins/inputs/s* (#10104)
Co-authored-by: Pawel Zak <Pawel Zak>
2021-11-18 09:04:52 -07:00
helotpl 56398237c4
feat: telegraf to merge tables with different indexes (#9241) 2021-09-28 15:24:08 -06:00
Mya b846c5069d
added a check for oid and name to prevent empty metrics (#9366) 2021-06-22 15:59:02 -05:00
Sven Rebhan 9853bf6c54
Get rid of deprecated internal.{Duration,Size,Number} (#8969) 2021-04-09 13:15:04 -04:00
Sven Rebhan 8e7da355b3
Linter fixes (unhandled errors) -- Part 1 (#8992) 2021-04-08 11:43:39 -05:00
Dušan Pajin 9ee6e034fb
Input SNMP plugin - upgrade gosnmp library to version 1.29.0 (#8588) 2021-01-07 08:44:33 -07:00
David Pryor ea4feb1a07
fixed formatting (+1 squashed commit) (#8541)
Squashed commits:
[c4e2bee2] Closes #8530: Extended the internal snmp wrapper to support AES192, AES192C, AES256, and AES256C.  Updated the example configuration with the new privProtocols.  Added the warning that those protocols are only supported if you have the appropriate tooling on your system.  Added test to ensure all 4 new privProtocols could be selected and properly encrypt the priv password.
2020-12-23 10:19:53 -06:00
Wiard van Rij 139498937a
Add support to convert snmp hex strings to integers (#8426) 2020-12-07 14:45:06 -07:00
Tuamas a7096c8128
Translate snmp field values (#8466) 2020-11-26 13:21:57 -05:00
Paweł Żak 0fcfee0caf
Fix tests for Windows - part 1 (#8414) 2020-11-23 10:40:32 -05:00
Alexandru Tudori 01eaa202d9
Add agent host tag configuration option (#8082) 2020-10-08 11:43:28 -04:00
reimda 6f9c623986
Add ifname processor plugin (#7763) 2020-07-07 15:37:53 -06:00
Mark Drayton 1bb436e8a8
Fix string to int64 conversion for SNMP input (#7407) 2020-04-24 13:35:59 -07:00
Daniel Nelson 8d647c4ebf
Fix URL agent address form with udp in snmp input (#6899) 2020-01-14 16:26:44 -08:00
Daniel Nelson c325c94a96
Rewrite documentation for snmp input (#6802) 2019-12-30 11:33:32 -08:00
reimda cec1bdce90 Add snmp_trap input plugin (#6629) 2019-11-25 11:56:21 -08:00
Felix Maurer 378c570c06 Add support for SNMP over TCP (#5870) 2019-11-07 10:56:51 -08:00
Trevor Pounds ee056278f5 Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
Patrick Hemmer 5ae2b02f5d Fix snmp overriding of auto-configured table fields (#4208)
Whenever the snmp plugin was configured with a table with automatic field
discovery, if one of those fields was explicitly overridden in the config and
the value of is_tag was changed, the field would be duplicated, once as a tag
& once as a field.

This change fixes the behavior so that if a field is explicitly configured,
automatic table field discovery doesn't touch it.
2018-05-29 19:03:37 -07:00
Matt 9ef902f4a1 Add snmp input option to strip non fixed length index suffixes (#4025) 2018-04-17 17:34:39 -07:00
Paul Myjavec 12d62e60b3 Use CircleCI 2.0 for builds (#3731) 2018-02-01 15:05:39 -08:00
Daniel Nelson a519abf13f Gather concurrently from snmp agents (#3365) 2017-10-25 15:28:55 -07:00
Patrick Hemmer 995546e7c6 snmp: support table indexes as tags (#2366) 2017-03-24 12:06:52 -07:00
Jonas Hahnfeld c4d4185fb5 snmp: Allow lines with empty or missing tags (#2172)
The changes in #1848 resulted in lines being dropped if they had an empty
tag. Let's allow all lines that have empty or missing tags!
2017-01-24 14:57:43 -08:00
Patrick Hemmer b58926dd26 snmp: use a shared global translation cache
Prevents the same data from being looked up multiple times. Also prevents multiple simultaneous lookups.

closes #2115
closes #2104
2016-12-12 13:32:42 +00:00
Patrick Hemmer 91143dda1a snmp: make snmptranslate not required (#2008) 2016-12-12 13:30:07 +00:00
Patrick Hemmer b48ad4b737 fix snmp emitting empty fields
closes #1848
closes #1835
2016-10-04 16:25:16 +01:00
Patrick Hemmer 9feb639bbd fix translating snmp fields not in MIB (#1846) 2016-10-04 16:22:15 +01:00
Cameron Sparr e7e39df6a0 Default SNMP parameter changes
max-repetitions = 10 is the default of net-snmp utils according to
http://net-snmp.sourceforge.net/docs/man/snmpbulkwalk.html

retries = 3 is the default of gosnmp:
https://godoc.org/github.com/soniah/gosnmp#pkg-variables

Could deal with some parts of the performance issues reported
by #1665
2016-09-28 14:34:20 +01:00
Patrick Hemmer 055ef168ae add oid_index_suffix to snmp plugin 2016-09-27 11:30:25 +01:00
Patrick Hemmer 2778b7be30 add snmp conversions for MAC addresses & IPs 2016-09-27 11:30:25 +01:00
Patrick Hemmer 953db51b2c Adjust snmp translation to return conversion info.
Also consolidated the translation code to obtain all info with just 1 command execution.

Also split test command mocks out to their own file for cleanliness.
2016-09-27 11:30:25 +01:00