* Linter fixes - revive:unused-parameter and unparam
* Linter fixes - revive:unused-parameter and unparam
* Linter fixes - revive:unused-parameter and unparam
* "nolint"'s removed
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
Co-authored-by: Pawel Zak <Pawel Zak>
* Use go-ping for "native" execution in Ping plugin
* Check for ipv6 and deadline out of go func
* ensure dns failure
* Move interval and timeout calc to init
Removed dns failure check, 3rd parties libary responsibility
* Rename timeout to avoid conflict
* Move native ping to interface
Update tests
* Check for zero length
First is to write an internal CombinedOutput and Run function with a
timeout.
Second, the following instances of command runners need to have timeouts:
plugins/inputs/ping/ping.go
125: out, err := c.CombinedOutput()
plugins/inputs/exec/exec.go
91: if err := cmd.Run(); err != nil {
plugins/inputs/ipmi_sensor/command.go
31: err := cmd.Run()
plugins/inputs/sysstat/sysstat.go
194: out, err := cmd.CombinedOutput()
plugins/inputs/leofs/leofs.go
185: defer cmd.Wait()
plugins/inputs/sysstat/sysstat.go
282: if err := cmd.Wait(); err != nil {
closes#1067
Paweł Żak
Thomas Casteleyn
Sebastian Spaink
Sven Rebhan
Steven Soroka
Helen Weller
Frank Riley
DasSkelett
dbutler-starry
Greg
Dheeraj Dwivedi
Lee Jaeyong
maxunt
Mariusz Brzeski
Margarita Bliznikova
everpcpc
Vladimir S
Daniel Nelson
Heston Kan
Patrick Hemmer
alekseyp
Cameron Sparr
Jack Zampolin
Thibault Cohen