* Linter fixes - revive:unused-parameter and unparam
* Linter fixes - revive:unused-parameter and unparam
* Linter fixes - revive:unused-parameter and unparam
* "nolint"'s removed
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
Co-authored-by: Pawel Zak <Pawel Zak>
Many of the examples provided within documentation are using a single
dash for the command line arguments, but the telegraf executable
explicitly has two dashes.
There are also some inconsistencies with the ordering of the command
line argument examples. I've ordered them so that the examples will
show: config, config-directory, input-filter, test
in this commit:
- centralize logging output handler.
- set global Info/Debug/Error log levels based on config file or flags.
- remove per-plugin debug arg handling.
- add a I!, D!, or E! to every log message.
- add configuration option to specify where to send logs.
closes#1786
First is to write an internal CombinedOutput and Run function with a
timeout.
Second, the following instances of command runners need to have timeouts:
plugins/inputs/ping/ping.go
125: out, err := c.CombinedOutput()
plugins/inputs/exec/exec.go
91: if err := cmd.Run(); err != nil {
plugins/inputs/ipmi_sensor/command.go
31: err := cmd.Run()
plugins/inputs/sysstat/sysstat.go
194: out, err := cmd.CombinedOutput()
plugins/inputs/leofs/leofs.go
185: defer cmd.Wait()
plugins/inputs/sysstat/sysstat.go
282: if err := cmd.Wait(); err != nil {
closes#1067
Joshua Powers
Sebastian Spaink
reimda
Sven Rebhan
Peter (Stig) Edwards
Joshua Powers
Mya
Paweł Żak
Greg
Daniel Nelson
Adrián López
Maximilien Richer
Zack Zatkin-Gold
Patrick Hemmer
Daniel Nelson
Cameron Sparr
David Moravek
Rene Zbinden