In #9488 the way that tags were built for procstat_lookup was changed
and it was only including the pid_finder and result tags. This is not
consistent with the documentation and is a regression from how they were
previously constructed.
Becuase of the large change to how procstat metrics are gathered, this
will use one of the process metric's tags as a basis for the tags for
procstat_lookup.
Resolves: #9793
### Required for all PRs:
- [ ] Updated associated README.md.
- [ ] Wrote appropriate unit tests.
Removed a pair of whitespace chars from the **sqlServerRingBufferCPU** SQL statement and added some formatting.
This query exists only for the on-prem version of SQL Server (`database_type = "SQLServer"`)
If you were unlucky enough to have some SQL 2008 the query wouldn't work as the whitespace char is not allowed inside the statement.
It's safer for dovecot to export metrics via a UDS instead of tcp port,
this will add support for that option.
### Required for all PRs:
<!-- Complete the tasks in the following list. Change [ ] to [x] to
show completion. -->
- [x] Updated associated README.md.
- [x] Wrote appropriate unit tests.
resolves#9215
dovecot: Add support for unix domain sockets as well
### Required for all PRs:
- [ ] Associated README.md updated.
- [ ] Has appropriate unit tests.
Associated to feature request - [Azure Active Directory (AAD) authentication support in SQL Server input plugin](https://github.com/influxdata/telegraf/issues/8808#issue-801695311)
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
* Add configurable option for the 'path' tag override in the Tail plugin.
* get test cases to pass
* update default config
* convert to configurable string field
* Couchbase new metrics for buckets
* updated
* update to simplify two different modes.
* cleanup code
* linter telling me to fix things I didn't do
* add include/exclude filter
* update sample config
* appease the linter
* Update README.md
* make all metrics configurable, defaults as just 'basic bucket metrics'
* check error in test
* Accept standard unix glob matching rules
* comply with indentation
* update readme
* move globing expand and url parsing into Init()
* chore: rebase branch on upstream master
* rename refreshFilePaths to expandFilePaths
* expandFilePaths handles '/path/to/*.pem' and 'files:///path/to/*.pem'
* update sample config
* fix: recompile files globing pattern at every gather tic
* add var globFilePathsToUrls to stack files path
* add var globpaths to stack compiled globpath
* rework sourcesToURLs to compile files path and stack them
* rename expandFilePaths to expandFilePathsToUrls
* rework expandFilePathsToUrls to only match compiled globpath
* rework the `Gather` ticker to match globpath at each call
* fix: comply with requested changes
* add specifics regarding relative paths in sample config
* add logger and use it in expandFilePathsToUrls()
* precompile glob for `files://`, `/` and `://`
* fix: update README to match last changes
* fix: comply with last requested changes
* rename expandFilePathsToUrls() to collectCertURLs()
* collectCertURLs() now returns []*url.URL to avoid extra field
globFilePathsToUrls in structure
* update the Gather() ticker accordingly
* fix(windows): do not try to compile glopath for windows path as it's not supposed to be supported by the OS
* fix(ci): apply go fmt
* fix(ci): empty-lines/import-shadowing
Co-authored-by: Anthony LE BERRE <aleberre@vente-privee.com>
* Linter fixes - revive:unused-parameter and unparam
* Linter fixes - revive:unused-parameter and unparam
* Linter fixes - revive:unused-parameter and unparam
* "nolint"'s removed
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
* Fixes for "varcheck" and "unused" added.
Co-authored-by: Pawel Zak <Pawel Zak>
* new k8 client
* Make all tests pass
* Update licenses
* add timeout back
* Resolve merge conflicts
* Fix tests and linter
* Fix linter errors
* Linting issues
* Extra empty line
Co-authored-by: Bas <3441183+BattleBas@users.noreply.github.com>
* Add query_clients_online to the teamspeak input plugin
* Update readme for teamspeak input plugin following introduction of new query_clients_online field
* Excluding data from system databases like msdb,model which are not
relevant for monitoring in Azure SQL
Please enter the commit message for your changes. Lines starting
* Addressing review comments to handle null scenarios
* Support 1.16
* Use 1.16 in mod file
* update go.sum
* update go.mod after updating to 1.16 locally
* Fix go vet
* Remove exit
* Use require.NoError
* Only run tidy explicitly in "dep" job
* install 1.16 for go
* typo
* update xcode
* specific version not working
* Get 1.16 go formula
* Change brew call
* brew update
* typo
* Resolve go.sum conflict
* go mod tidy
Telegraf daemonset pod cannot contact kube-apiserver via localhost.
Should be `$HOSTIP`, and the default port is 6443.
Co-authored-by: Paul Choi <pchoi@apple.com>
* Fix the issue
* Remove test I was using for replication
* Accidentally removed test.
* Add lock only where it is necessary.
* eliminate unnecessary space
* Revive fixes regarding following set of rules:
[rule.if-return]
[rule.increment-decrement]
[rule.var-declaration]
[rule.package-comments]
[rule.receiver-naming]
[rule.unexported-return]
* Replace exclamation mark with caret
* Update README and use table driven tests
* Use ReplaceAll instead
* Use doublestar package instead to glob filepath
* Add license
* Fix order of dependencies
* Doc improvement, maybe better then str replace?
* Forgot to remove nil from test
* Use regex instead of library
* Revert unnecessary change
* Go back to using library
replace string twice to handle edge case
* Add support for datadog distributions in statsd
* Parse metric distribution correctly
* Add tests to check distributions are parsed correctly
* Update Statsd plugin Readme with details about Distributions metric
* Refactor metric distribution initialization code
* Update distribution metric interface to replace fields with value
* Refactor statsd distribution metric test code
* Fix go formatting errors
* Add tests to parse only when DataDog Distributions config is enabled
* Add config to enable parsing DataDog Statsd Distributions
* Document use of datadog_distributions config in Readme
* improve mntr regex to match user specific keys.
* Update plugins/inputs/zookeeper/zookeeper.go
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Co-authored-by: guoxu <guoxu@chinatelecom.cn>
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
* Use go-ping for "native" execution in Ping plugin
* Check for ipv6 and deadline out of go func
* ensure dns failure
* Move interval and timeout calc to init
Removed dns failure check, 3rd parties libary responsibility
* Rename timeout to avoid conflict
* Move native ping to interface
Update tests
* Check for zero length
* GNMI plugin should not take off the first character of field keys when no 'alias path' exists.
* fix test method name
* fix test file formatting
* fix test file formatting
* Remove my unnecessary failing test
This plugin is known to work with Kafkabeat and Filebeat, and will
likely work with other Beat instances that have a similar HTTP API.
It is based on work done by @dmitryilyin.
Co-authored-by: Dmitry Ilyin <idv1985@gmail.com>
* tls_config: Allow specifying SNI hostnames
Add a new configration field `tls_server_name` that allows specifying
the server name that'll be sent in the ClientHello when telegraf makes
a request to TLS servers. This allows checking against load balancers
responding to specific hostnames that otherwise wouldn't resolve to
their addresses.
Add the setting to the documentation of common TLS options, as well as
to the http_response plugin.
Fixes#7598.
* Adjust the x509_cert to allow usage of tls_server_name
This plugin has been using ServerName previously, and will have to
deal with the new setting, too: Extract the server-name choosing into
a method & add a test to ensure we choose the right value (and error
under the right circumstances). Also document that the two settings
are mutually exclusive.
* Improve documentation on what we try to accomplish in the nil return
Also get rid of the TODO, as I am fairly certain this behavior is the
correct one.
* Remove unused struct field in tests
Squashed commits:
[c4e2bee2] Closes#8530: Extended the internal snmp wrapper to support AES192, AES192C, AES256, and AES256C. Updated the example configuration with the new privProtocols. Added the warning that those protocols are only supported if you have the appropriate tooling on your system. Added test to ensure all 4 new privProtocols could be selected and properly encrypt the priv password.
* [http_listener_v2] Stop() succeeds even if fails to start
In cases where the http_listener_v2 plugin config is invalid, when the agent attempts to cleanup by stopping all the inputs, the Stop method here panics as it tries to call listener.Stop() when no listener has been set. This also masks the error message returned from the Start method.
```
> telegraf --test
2020-10-27T12:21:45Z I! Starting Telegraf 1.16.0
2020-10-27T12:21:45Z I! Using config file: /etc/telegraf/telegraf.conf
...
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x1245130]
goroutine 45 [running]:
github.com/influxdata/telegraf/plugins/inputs/http_listener_v2.(*HTTPListenerV2).Stop(0xc00043e000)
/go/src/github.com/influxdata/telegraf/plugins/inputs/http_listener_v2/http_listener_v2.go:178 +0x30
github.com/influxdata/telegraf/agent.stopServiceInputs(0xc00045e480, 0x5, 0x8)
/go/src/github.com/influxdata/telegraf/agent/agent.go:445 +0x82
github.com/influxdata/telegraf/agent.(*Agent).testRunInputs(0xc000288080, 0x32be8c0, 0xc0000f1f00, 0x0, 0xc00000f480, 0x0, 0x0)
/go/src/github.com/influxdata/telegraf/agent/agent.go:434 +0x1b7
github.com/influxdata/telegraf/agent.(*Agent).test.func4(0xc000057b70, 0xc000288080, 0x32be8c0, 0xc0000f1f00, 0x0, 0xc00000f480)
/go/src/github.com/influxdata/telegraf/agent/agent.go:977 +0x8b
created by github.com/influxdata/telegraf/agent.(*Agent).test
/go/src/github.com/influxdata/telegraf/agent/agent.go:975 +0x352
```
This fixes this issue by checking if the listener has been set before calling listener.Stop.
```
> ./telegraf --config test.conf --test
2020-10-27T12:43:25Z I! Starting Telegraf
2020-10-27T12:43:25Z E! [agent] Starting input inputs.http_listener_v2: listen tcp: address address_without_port: missing port in address
```
* retry CI
Add configurable number of 'most recent' date-stamped indices to gather in the Elasticsearch input plugin, and allow wildcards to account for date-suffixed index names. Configuring '3' for num_most_recent_indices will only gather the 3 latest indices, based on the date or number they end with. Finding the date or number is dependent on the targeted indices being configured with wildcards at the end of their 'base' names.
* Allow glob patterns in config
* Update README
* Move creating filter to init
* Need to explictly call init
Co-authored-by: Bas <3441183+BattleBas@users.noreply.github.com>
Felix Edelmann
Sebastian Spaink
xavpaice
etycomputer
Yuji Kawamoto
Joshua Powers
Howard Yoo
Guo Qiao (Joe)
Samantha Wang
Alexander Krantz
helotpl
Eng Zer Jun
Sven Rebhan
Jacob Marble
John Seekins
Sean Molenaar
Sanyam Arya
Doron-Bargo
Mariusz Białończyk
Matteo Concas
David B
Grace Wehner
Eugene Klimov
Marcus Ilgner
varunjain0606
Marius Bezuidenhout
R290
Helen Weller
Roger Coll Aumatell
Paweł Żak
Martin Molnar
bhsu-ms
Raphael Yu
Dominik Rosiek
Mark Wilkinson - m82labs
Imran Ismail
Mya
Jacob Hochstetler
Madhushree Sreenivasa
Russ Savage
Andre Nathan
Mat Wood
reimda
Dmitry Alimov
Niek Bruins
Brian Lamar
Jarno Huuskonen
Leandro Piccilli
Jörg Thalheim
Jack Henschel
Vyacheslav Stepanov
Pascal Zimmermann
Chris Dagenais
Victor Marinsky
Rajiv Kushwaha
Giovanni Luisotto
Erikas
maxuntr
Josef Johansson
Adam Dobrawy
SomKen
i-prudnikov
Paweł Żak
David Bennett
Avinash Nigam
Gennady
Wilfried OLLIVIER
Thomas Casteleyn
Pontus Rydin
Mattias Jiderhamn
Cláudio Silva
jaroug
Aladex
Steven Soroka
Dominic Tootell
Sven Rebhan
Felix Moessbauer
Shangxin Du
Denis Pershin
Josh Keegan
Daniel Moran
Connor Quagliana
Grace Wehner
Paul Choi
Pmoranga
Marcin Lewandowski
oofdog
Andrés Álvarez
Patrick Koenig
Antonio Garcia
Niels Huylebroeck
Andreas Fuchs
sarvanikonda
Sreejith Pp
viperstars
Johannes Deger
Shawn Guo
omgold
A. Binzxxxxxx
Dae-Ho Kim
Földi Tamás
Nathan Ferch
Dušan Pajin
David Pryor
Greg
JS1010111
Peng Xiao
Sam Lai
Aleksei Magusev
vhqtvn
Oleksandr
Joshua Gross