jessequ
/
AMQP-CPP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

prevent crash when channelimpl unregistered from the connectionimpl, (hopefully) fixes #299 and fixes #326

This commit is contained in:
Emiel Bruijntjes 2020-03-13 09:44:29 +01:00
parent 7124975d4f
commit da26b1112e
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/channelimpl.cpp
View File

@ -855,10 +855,20 @@ void ChannelImpl::reportError(const char *message, bool notifyhandler)
// leap out if object no longer exists // leap out if object no longer exists
if (!monitor.valid()) return; if (!monitor.valid()) return;
// done when the channel was already no longer associated with a connection
if (!_connection) return;
// when we call _connection->remove(this), it is possible that the last reference
// to the channelimpl is also dropped and that the object immediately destructs,
// this is something that we want to prevent so we create an extra reference to the object here
auto self = shared_from_this();
// the connection no longer has to know that this channel exists, // the connection no longer has to know that this channel exists,
// because the channel ID is no longer in use // because the channel ID is no longer in use
if (_connection) _connection->remove(this); _connection->remove(this);
// remember that we're no longer associated with a connection
_connection = nullptr; _connection = nullptr;
} }