jessequ
/
qamqp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

micro optimizations 

These are paths that we can optimize for since they are unlikely
to occur.
This commit is contained in:
Matt Broadstone 2015-01-15 07:27:19 -05:00
parent ad19dc326d
commit 8be77044ef
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/qamqpclient.cpp
View File

@ -203,7 +203,7 @@ void QAmqpClientPrivate::_q_readyRead()
const char *bufferData = buffer.constData(); const char *bufferData = buffer.constData();
const quint8 type = *(quint8*)&bufferData[0]; const quint8 type = *(quint8*)&bufferData[0];
const quint8 magic = *(quint8*)&bufferData[QAmqpFrame::HEADER_SIZE + payloadSize]; const quint8 magic = *(quint8*)&bufferData[QAmqpFrame::HEADER_SIZE + payloadSize];
if (magic != QAmqpFrame::FRAME_END) { if (Q_UNLIKELY(magic != QAmqpFrame::FRAME_END)) {
close(QAMQP::UnexpectedFrameError, "wrong end of frame"); close(QAMQP::UnexpectedFrameError, "wrong end of frame");
return; return;
} }
@ -215,7 +215,7 @@ void QAmqpClientPrivate::_q_readyRead()
QAmqpMethodFrame frame; QAmqpMethodFrame frame;
streamB >> frame; streamB >> frame;
if (frame.size() > frameMax) { if (Q_UNLIKELY(frame.size() > frameMax)) {
close(QAMQP::FrameError, "frame size too large"); close(QAMQP::FrameError, "frame size too large");
return; return;
} }
@ -233,10 +233,10 @@ void QAmqpClientPrivate::_q_readyRead()
QAmqpContentFrame frame; QAmqpContentFrame frame;
streamB >> frame; streamB >> frame;
if (frame.size() > frameMax) { if (Q_UNLIKELY(frame.size() > frameMax)) {
close(QAMQP::FrameError, "frame size too large"); close(QAMQP::FrameError, "frame size too large");
return; return;
} else if (frame.channel() <= 0) { } else if (Q_UNLIKELY(frame.channel() <= 0)) {
close(QAMQP::ChannelError, "channel number must be greater than zero"); close(QAMQP::ChannelError, "channel number must be greater than zero");
return; return;
} }
@ -250,10 +250,10 @@ void QAmqpClientPrivate::_q_readyRead()
QAmqpContentBodyFrame frame; QAmqpContentBodyFrame frame;
streamB >> frame; streamB >> frame;
if (frame.size() > frameMax) { if (Q_UNLIKELY(frame.size() > frameMax)) {
close(QAMQP::FrameError, "frame size too large"); close(QAMQP::FrameError, "frame size too large");
return; return;
} else if (frame.channel() <= 0) { } else if (Q_UNLIKELY(frame.channel() <= 0)) {
close(QAMQP::ChannelError, "channel number must be greater than zero"); close(QAMQP::ChannelError, "channel number must be greater than zero");
return; return;
} }
@ -267,7 +267,7 @@ void QAmqpClientPrivate::_q_readyRead()
QAmqpMethodFrame frame; QAmqpMethodFrame frame;
streamB >> frame; streamB >> frame;
if (frame.channel() != 0) { if (Q_UNLIKELY(frame.channel() != 0)) {
close(QAMQP::FrameError, "heartbeat must have channel id zero"); close(QAMQP::FrameError, "heartbeat must have channel id zero");
return; return;
} }